Tests: fix X509_check_private_key() usage

Author: olszomal

tests/check-all-prov.c

@@ -66,8 +66,7 @@ int main(int argc, char *argv[])
 		printf("Cannot load certificate: %s\n", argv[1]);
 		goto cleanup;
 	}
-	ret = X509_check_private_key(obj_set->cert, obj_set->private_key);
-	if (!ret) {
+	if (!X509_check_private_key(obj_set->cert, obj_set->private_key)) {
 		printf("Could not check private key.\n");
 		display_openssl_errors();
 		goto cleanup;

tests/check-privkey-prov.c

@@ -66,8 +66,7 @@ int main(int argc, char *argv[])
 	}
 	printf("Private key found.\n");
 
-	ret = X509_check_private_key(cert, private_key);
-	if (!ret) {
+	if (!X509_check_private_key(cert, private_key)) {
 		printf("Could not check private key.\n");
 		display_openssl_errors();
 		goto cleanup;

tests/check-privkey.c

@@ -171,14 +171,14 @@ int main(int argc, char *argv[])
 	/* Free the functional reference from ENGINE_init */
 	ENGINE_finish(engine);
 
-	ret = X509_check_private_key(cert, pkey);
-	EVP_PKEY_free(pkey);
-	if (!ret) {
+	if (!X509_check_private_key(cert, pkey)) {
 		printf("Could not check private key\n");
 		display_openssl_errors(__LINE__);
+		EVP_PKEY_free(pkey);
 		ret = 1;
 		goto end;
 	}
+	EVP_PKEY_free(pkey);
 
 	printf("Key and certificate matched\n");
 	ret = 0;