Skip to content

Commit 1359ba8

Browse files
authored
Merge pull request #1973 from jan-cerny/unused_variables
Remove unused variables
2 parents fd5c9db + 2c3f95b commit 1359ba8

File tree

4 files changed

+2
-10
lines changed

4 files changed

+2
-10
lines changed

src/CPE/cpelang_priv.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,6 @@ struct cpe_testexpr *cpe_testexpr_parse(xmlTextReaderPtr reader)
313313
{
314314

315315
xmlChar *temp = NULL;
316-
size_t elem_cnt = 0;
317316
struct cpe_testexpr *ret = NULL;
318317

319318
__attribute__nonnull__(reader);
@@ -381,7 +380,6 @@ struct cpe_testexpr *cpe_testexpr_parse(xmlTextReaderPtr reader)
381380
xmlTextReaderNextNode(reader);
382381
continue;
383382
}
384-
elem_cnt++;
385383

386384
// We assume that the expression is a logical one (meaning that it
387385
// can have subexpressions).
@@ -390,7 +388,6 @@ struct cpe_testexpr *cpe_testexpr_parse(xmlTextReaderPtr reader)
390388
// .. and the next node is logical-test element, we need recursive call
391389
if (!xmlStrcmp(xmlTextReaderConstLocalName(reader), TAG_LOGICAL_TEST_STR) &&
392390
xmlTextReaderNodeType(reader) == XML_READER_TYPE_ELEMENT) {
393-
// ret->meta.expr[elem_cnt - 1] = *(cpe_testexpr_parse(reader));
394391
oscap_list_add(ret->meta.expr, cpe_testexpr_parse(reader));
395392
if (xmlTextReaderDepth(reader) < depth) {
396393
return ret;
@@ -420,7 +417,6 @@ struct cpe_testexpr *cpe_testexpr_parse(xmlTextReaderPtr reader)
420417
}
421418
xmlTextReaderNextNode(reader);
422419
}
423-
//ret->meta.expr[elem_cnt].oper = CPE_LANG_OPER_HALT;
424420

425421
return ret;
426422
}

src/OVAL/oval_object.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -439,8 +439,7 @@ xmlNode *oval_object_to_dom(struct oval_object *object, xmlDoc * doc, xmlNode *
439439
oval_behavior_iterator_free(behaviors);
440440

441441
struct oval_object_content_iterator *contents = oval_object_get_object_contents(object);
442-
int i;
443-
for (i = 0; oval_object_content_iterator_has_more(contents); i++) {
442+
while (oval_object_content_iterator_has_more(contents)) {
444443
struct oval_object_content *content = oval_object_content_iterator_next(contents);
445444
oval_object_content_to_dom(content, doc, object_node);
446445
}

src/OVAL/oval_sysInfo.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,6 @@ void oval_sysinfo_to_dom(struct oval_sysinfo *sysinfo, xmlDoc * doc, xmlNode * t
307307
{
308308
xmlNode *nodestr, *nodelst;
309309
xmlDoc *docstr;
310-
int i;
311310

312311
if (sysinfo) {
313312
xmlNs *ns_syschar = xmlSearchNsByHref(doc, tag_parent, OVAL_SYSCHAR_NAMESPACE);
@@ -320,7 +319,7 @@ void oval_sysinfo_to_dom(struct oval_sysinfo *sysinfo, xmlDoc * doc, xmlNode * t
320319

321320
xmlNode *tag_interfaces = xmlNewTextChild(tag_sysinfo, ns_syschar, BAD_CAST "interfaces", NULL);
322321
struct oval_sysint_iterator *intrfcs = oval_sysinfo_get_interfaces(sysinfo);
323-
for (i = 1; oval_sysint_iterator_has_more(intrfcs); i++) {
322+
while (oval_sysint_iterator_has_more(intrfcs)) {
324323
struct oval_sysint *intrfc = oval_sysint_iterator_next(intrfcs);
325324
oval_sysint_to_dom(intrfc, doc, tag_interfaces);
326325
}

src/OVAL/probes/probe-api.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -871,7 +871,6 @@ oval_syschar_collection_flag_t probe_cobj_compute_flag(SEXP_t *cobj)
871871
SEXP_t *items, *item;
872872
int error_cnt = 0;
873873
int exists_cnt = 0;
874-
int does_not_exist_cnt = 0;
875874
int not_collected_cnt = 0;
876875

877876
items = probe_cobj_get_items(cobj);
@@ -884,7 +883,6 @@ oval_syschar_collection_flag_t probe_cobj_compute_flag(SEXP_t *cobj)
884883
++exists_cnt;
885884
break;
886885
case SYSCHAR_STATUS_DOES_NOT_EXIST:
887-
++does_not_exist_cnt;
888886
break;
889887
case SYSCHAR_STATUS_NOT_COLLECTED:
890888
++not_collected_cnt;

0 commit comments

Comments
 (0)