fix a vicious issue in list.remove on iterable objects

Author: DominiqueDevinci

swig/openscap_api.py

@@ -78,15 +78,36 @@ def remove(self, item):
         """Function to remove item from list. This removed item should be also
         removed from parent oscap list. This function is supported only if there exists
         reset function on iterators. Exception is throwed otherwise."""
-
         try:
             self.iterator.reset()
             while self.iterator.has_more():
                 litem = self.iterator.next()
                 if (type(item) == str and type(litem) == str and litem == item) or \
                         ("instance" in item.__dict__ and litem.instance == item.instance):
+                            
                     self.iterator.remove()
-                    list.remove(self, item)
+                    
+                    
+                    '''
+                    Warning, list.remove(self, item) will fail because python yield
+                    a new reference at each loop. So wee need to loop again into the python list,
+                    get the new reference and remove it. Demo:
+                    
+                    print(item.instance)
+                    print(litem.instance)
+                    print(litem.instance == item.instance) 
+                    
+                    RETURNS: 
+                    
+                    <Swig Object of type 'struct xccdf_refine_value *' at 0x7ff85ed73bd0>
+                    <Swig Object of type 'struct xccdf_refine_value *' at 0x7ff85ed73c90>
+                    True
+                    '''
+                    
+                    for i in self[:]:
+                        if "instance" in item.__dict__  and i.instance == item.instance:
+                            list.remove(self, i)
+
         except NameError:
             raise Exception("Removing %s items throught oscap list is not allowed. "
                             "Please use appropriate function."
@@ -103,6 +124,8 @@ def generate(self, iterator):
 
         while iterator.has_more():
             list.append(self, iterator.next())
+            
+            
 
     def append(self, item, n=1):
         """This function is not allowed. Please use appropriate function from library."""
@@ -623,10 +646,11 @@ def set_tailor_items(self, items):
 
             oper = remarks = setvalue = None
             for r_value in self.profile.refine_values[:]:
-                if r_value.item == item["id"] and r_value in self.profile.refine_values:
+                if r_value.item == item["id"]:
                     oper = r_value.oper
                     remarks = r_value.remarks
                     self.profile.refine_values.remove(r_value)
+
             for s_value in self.profile.setvalues[:]:
                 if s_value.item == item["id"]:
                     setvalue = s_value.value