Merge pull request #1217 from yuumasato/do_not_free_oscap_source_when_parsing_cvrf_xml

Don't free oscap_source when parsing cvrf_xml

Author: jan-cerny

src/CVRF/cvrf_priv.c

@@ -2333,7 +2333,6 @@ struct cvrf_index *cvrf_index_parse_xml(struct oscap_source *index_source) {
 	}
 	struct cvrf_index *index = cvrf_index_new();
 	cvrf_index_set_index_file(index, oscap_source_readable_origin(index_source));
-	oscap_source_free(index_source);
 	return index;
 }
 

utils/oscap-cvrf.c

@@ -151,9 +151,7 @@ static int app_cvrf_export(const struct oscap_action *action) {
 		if (oscap_err())
 			fprintf(stderr, "%s %s\n", OSCAP_ERR_MSG, oscap_err_desc());
 
-	/* TODO: Refactor, cvrf_index_parse_xml (called by oscap_source_new_from_file) frees its argument as an unexpected side-effect.
-	 * oscap_source_free(import_source);
-	 */
+	oscap_source_free(import_source);
 	free(action->cvrf_action);
 	return result;
 }