Merge pull request #1413 from vojtapolasek/comment_a11y

yuumasato · web-flow · commit 30e193190933 · 2019-10-31T13:41:01.000+01:00
added a comment about not removing attributes improving a11y
diff --git a/xsl/xccdf-resources/openscap.js b/xsl/xccdf-resources/openscap.js
@@ -2,6 +2,8 @@ function openRuleDetailsDialog(rule_result_id)
 {
     $("#detail-modal").remove();
 
+    /*DO NOT remove the aria-hidden="false" attribute from the following lines!
+    This attribute ensures that rule detail can be accessed by accessibility technologies such as screenreaders.*/
     var closebutton = $('<button type="button" class="close btn btn-sm btn-default" data-dismiss="modal" aria-hidden="false" title="Close">&#x274c;</button>');
     var modal = $('<div id="detail-modal" class="modal fade" tabindex="-1" role="dialog" aria-hidden="false"><div id="detail-modal-body" class="modal-body"></div></div>');
 

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,8 @@ function openRuleDetailsDialog(rule_result_id)`
`2`	`2`	`{`
`3`	`3`	`$("#detail-modal").remove();`
`4`	`4`
	`5`	`+ /*DO NOT remove the aria-hidden="false" attribute from the following lines!`
	`6`	`+ This attribute ensures that rule detail can be accessed by accessibility technologies such as screenreaders.*/`
`5`	`7`	`var closebutton = $('<button type="button" class="close btn btn-sm btn-default" data-dismiss="modal" aria-hidden="false" title="Close">❌</button>');`
`6`	`8`	`var modal = $('<div id="detail-modal" class="modal fade" tabindex="-1" role="dialog" aria-hidden="false"><div id="detail-modal-body" class="modal-body"></div></div>');`
`7`	`9`