Skip to content

Commit 3473345

Browse files
committed
Explicitly mark NOOPs and empty branches with FIXMEs
Not really a fix, but it raises visibility of the problem.
1 parent d18170a commit 3473345

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/CPE/cpename.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -303,9 +303,8 @@ struct cpe_name *cpe_name_new(const char *cpestr)
303303

304304
free(data_);
305305
free(fields_);
306-
}
307-
else if (format == CPE_FORMAT_WFN)
308-
{
306+
} else if (format == CPE_FORMAT_WFN) {
307+
/* FIXME: Do something here or remove the branch */
309308
}
310309
}
311310
return cpe;

src/OVAL/probes/unix/gconf_probe.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,7 @@ int gconf_probe_main(probe_ctx *ctx, void *probe_arg)
222222
collect_item_direct(ctx, gconf_addr, gconf_engine, gconf_key);
223223
break;
224224
case OVAL_OPERATION_PATTERN_MATCH:
225+
/* FIXME: This is a NOOP call */
225226
collect_item_regexp(ctx, gconf_addr, gconf_engine, gconf_key);
226227
break;
227228
default:
@@ -249,6 +250,7 @@ int gconf_probe_main(probe_ctx *ctx, void *probe_arg)
249250
collect_item_direct(ctx, NULL, gconf_engine, gconf_key);
250251
break;
251252
case OVAL_OPERATION_PATTERN_MATCH:
253+
/* FIXME: This is a NOOP call */
252254
collect_item_regexp(ctx, NULL, gconf_engine, gconf_key);
253255
break;
254256
default:

0 commit comments

Comments
 (0)