Skip to content

Commit e0e07d0

Browse files
committed
Check if printf argument is NULL
In function ‘_print_xccdf_tailoring_header’, inlined from ‘_print_xccdf_tailoring’ at /home/jcerny/openscap/utils/oscap-info.c:279:2, inlined from ‘app_info_single_ds_profiles_only’ at /home/jcerny/openscap/utils/oscap-info.c:336:4, inlined from ‘app_info_single_ds’ at /home/jcerny/openscap/utils/oscap-info.c:513:18, inlined from ‘app_info_sds’ at /home/jcerny/openscap/utils/oscap-info.c:545:7, inlined from ‘app_info’ at /home/jcerny/openscap/utils/oscap-info.c:657:7: /home/jcerny/openscap/utils/oscap-info.c:273:2: warning: ‘%s’ directive argument is null [-Wformat-overflow=] 273 | printf("%sBenchmark Hint: %s\n", prefix, xccdf_tailoring_get_benchmark_ref(tailoring)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 parent adcb940 commit e0e07d0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

utils/oscap-info.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ static inline void _print_xccdf_tailoring_header(struct xccdf_tailoring *tailori
270270
if (tailoring == NULL) {
271271
return;
272272
}
273-
printf("%sBenchmark Hint: %s\n", prefix, xccdf_tailoring_get_benchmark_ref(tailoring));
273+
printf("%sBenchmark Hint: %s\n", prefix ? prefix : "", xccdf_tailoring_get_benchmark_ref(tailoring));
274274
}
275275

276276
static inline void _print_xccdf_tailoring(struct oscap_source *source, const char *prefix, void (*print_one_profile)(const struct xccdf_profile *, const char *))

0 commit comments

Comments
 (0)