Specify size of the buffer in fscanf

jan-cerny · jan-cerny · commit fd20e520f57a · 2018-10-08T10:47:42.000+02:00
The terminating null byte is not included in the length.
diff --git a/src/OVAL/probes/unix/linux/iflisteners.c b/src/OVAL/probes/unix/linux/iflisteners.c
@@ -353,7 +353,7 @@ static int get_interface(const int ent_ifindex, struct interface_t *interface) {
 				*(interface->hw_address) = '\0';
 			}
 			else {
-				if (fscanf(fd, "%s\n", buf) < 1)
+				if (fscanf(fd, "%254s\n", buf) < 1)
 					*buf = '\0';
 
 				snprintf(interface->hw_address, sizeof interface->hw_address, "%s", buf);

Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,7 @@ static int get_interface(const int ent_ifindex, struct interface_t *interface) {`
`353`	`353`	`*(interface->hw_address) = '\0';`
`354`	`354`	`}`
`355`	`355`	`else {`
`356`		`- if (fscanf(fd, "%s\n", buf) < 1)`
	`356`	`+ if (fscanf(fd, "%254s\n", buf) < 1)`
`357`	`357`	`*buf = '\0';`
`358`	`358`
`359`	`359`	`snprintf(interface->hw_address, sizeof interface->hw_address, "%s", buf);`