Test is_local_fs

Adds a simple unit test that checks whether autofs entries in
/etc/mtab are not considered local.

Author: jan-cerny

src/OVAL/probes/fsdev.c

@@ -118,8 +118,7 @@ static int match_fs(const char *fsname, const char **fs_arr, size_t fs_cnt)
 #define DEVID_ARRAY_ADD  8
 
 #if defined(__linux__)
-static int
-is_local_fs(struct mntent *ment)
+int is_local_fs(struct mntent *ment)
 {
 // todo: would it be usefull to provide the choice during build-time?
 #if 1
@@ -169,8 +168,7 @@ is_local_fs(struct mntent *ment)
 }
 
 #elif defined(_AIX)
-static int
-is_local_fs(struct mntent *ment)
+int is_local_fs(struct mntent *ment)
 {
 	int i;
 	struct vfs_ent *e;

src/OVAL/probes/public/fsdev.h

@@ -36,6 +36,10 @@
 #include <stdint.h>
 #include <sys/stat.h>
 
+#if defined(__linux__) || defined(_AIX)
+#include <mntent.h>
+#endif
+
 /**
  * Filesystem device structure.
  */
@@ -88,5 +92,15 @@ int fsdev_path(fsdev_t * lfs, const char *path);
  */
 int fsdev_fd(fsdev_t * lfs, int fd);
 
+#if defined(__linux__) || defined(_AIX)
+/**
+ * Detemines whether a given mtab entry is a local file system.
+ * @param ment Structure returned by getmntent (see `man 3 getmntent`).
+ * @retval 1 if local
+ * @retval 0 otherwise
+ */
+int is_local_fs(struct mntent *ment);
+#endif
+
 #endif				/* FSDEV_H */
 /// @}

tests/API/probes/Makefile.am

@@ -26,14 +26,16 @@ TESTS_ENVIRONMENT = \
 		$(top_builddir)/run
 
 TESTS = all.sh
-check_PROGRAMS = test_api_probes_smoke oval_fts_list
+check_PROGRAMS = test_api_probes_smoke oval_fts_list test_fsdev_is_local_fs
 
 test_api_probes_smoke_SOURCES = test_api_probes_smoke.c
 oval_fts_list_CFLAGS= -I$(top_srcdir)/src/OVAL/probes
 oval_fts_list_SOURCES= oval_fts_list.c
+test_fsdev_is_local_fs_SOURCES = test_fsdev_is_local_fs.c
 
 EXTRA_DIST += \
 	all.sh \
 	fts.sh \
 	gentree.sh \
-	test_api_probes_smoke.c
+	test_api_probes_smoke.c \
+	test_fsdev_is_local_fs.c

tests/API/probes/all.sh

@@ -7,6 +7,7 @@ test_init "test_api_probes.log"
 if [ -z ${CUSTOM_OSCAP+x} ] ; then
     test_run "fts test" $srcdir/fts.sh
     test_run "probe api smoke test" ./test_api_probes_smoke
+    test_run "fsdev is_local_fs unit test" ./test_fsdev_is_local_fs
 fi
 
 test_exit

tests/API/probes/test_fsdev_is_local_fs.c

@@ -0,0 +1,41 @@
+/*
+ * Copyright 2019 Red Hat Inc., Durham, North Carolina.
+ * All Rights Reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ *
+ * Authors:
+ *      "Jan Černý" <[email protected]>
+ */
+
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
+#include <stdio.h>
+#include <string.h>
+#include <mntent.h>
+#include "fsdev.h"
+
+int main(int argc, char *argv[])
+{
+	struct mntent ment;
+	ment.mnt_type = "autofs";
+	int ret = is_local_fs(&ment);
+	if (ret != 0) {
+		return 1;
+	}
+	return 0;
+}