Fix rubocop: Style/UnneededCondition

isimluk · isimluk · commit 749be456cc35 · 2019-05-18T17:43:38.000+02:00
Addressing:
lib/openscap/xccdf/rule.rb:21:36: C: Style/UnneededCondition: Use double pipes || instead.
        severity_mapping[severity] ? severity_mapping[severity] : severity_mapping[:xccdf_unknown]
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
diff --git a/lib/openscap/xccdf/rule.rb b/lib/openscap/xccdf/rule.rb
@@ -18,7 +18,7 @@ def severity
           :xccdf_medium => 'Medium',
           :xccdf_high => 'High'
         }
-        severity_mapping[severity] ? severity_mapping[severity] : severity_mapping[:xccdf_unknown]
+        severity_mapping[severity] || severity_mapping[:xccdf_unknown]
       end
 
       def fixes

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ def severity`
`18`	`18`	`:xccdf_medium => 'Medium',`
`19`	`19`	`:xccdf_high => 'High'`
`20`	`20`	`}`
`21`		`- severity_mapping[severity] ? severity_mapping[severity] : severity_mapping[:xccdf_unknown]`
	`21`	`+ severity_mapping[severity] \|\| severity_mapping[:xccdf_unknown]`
`22`	`22`	`end`
`23`	`23`
`24`	`24`	`def fixes`