Skip to content

Commit 9717e2d

Browse files
committed
Rubocop wants us not to use !=0
Let's revert conditions and use `zero?` predicate. Addressing rubocop comments like: C: Use **.nonzero? instead of ** != 0.
1 parent 500e1ad commit 9717e2d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/openscap/source.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def type
3737

3838
def validate!
3939
e = FFI::MemoryPointer.new(:char, 4096)
40-
if 0 != OpenSCAP.oscap_source_validate(@raw, XmlReporterCallback, e)
40+
unless OpenSCAP.oscap_source_validate(@raw, XmlReporterCallback, e).zero?
4141
OpenSCAP.raise! e.read_string
4242
end
4343
end

lib/openscap/xccdf/session.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def load(opts = {})
3232
OpenSCAP.xccdf_session_set_datastream_id(@s, o[:datastream_id])
3333
OpenSCAP.xccdf_session_set_component_id(@s, o[:component_id])
3434
end
35-
OpenSCAP.raise! if OpenSCAP.xccdf_session_load(@s) != 0
35+
OpenSCAP.raise! unless OpenSCAP.xccdf_session_load(@s).zero?
3636
OpenSCAP.raise! unless OpenSCAP.xccdf_session_load_check_engine_plugins(@s) == 0
3737
end
3838

@@ -44,7 +44,7 @@ def profile=(p)
4444
end
4545

4646
def evaluate
47-
OpenSCAP.raise! if OpenSCAP.xccdf_session_evaluate(@s) != 0
47+
OpenSCAP.raise! unless OpenSCAP.xccdf_session_evaluate(@s).zero?
4848
end
4949

5050
def remediate

0 commit comments

Comments
 (0)