Skip to content
This repository was archived by the owner on Sep 27, 2024. It is now read-only.

Commit af528f8

Browse files
authored
Merge pull request #259 from carlosmmatos/cmm-qt5-update-support
Use QT provided macro function to version check - deprecation errors
2 parents a1b6f66 + 806be58 commit af528f8

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

src/SaveAsRPMDialog.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,12 @@ void SaveAsRPMDialog::slotFinished(int result)
8686
closure.remove(mScanningSession->getOpenedFilePath());
8787
QList<QString> closureOrdered;
8888
closureOrdered.append(mScanningSession->getOpenedFilePath());
89-
closureOrdered.append(closure.toList());
89+
#if (QT_VERSION >= QT_VERSION_CHECK(5, 14, 0))
90+
closureOrdered.append(closure.values());
91+
#else
92+
// support older versions where deprecation warning is not fatal
93+
closureOrdered.append(closure.toList());
94+
#endif
9095

9196
const QDir cwd = ScanningSession::getCommonAncestorDirectory(closure);
9297

src/TailoringWindow.cpp

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,12 @@ QString TailoringWindow::getQSettingsKey() const
645645
void TailoringWindow::deserializeCollapsedItems()
646646
{
647647
const QStringList list = mQSettings->value(getQSettingsKey()).toStringList();
648-
mCollapsedItemIds = QSet<QString>::fromList(list);
648+
#if (QT_VERSION >= QT_VERSION_CHECK(5, 14, 0))
649+
mCollapsedItemIds = QSet<QString>(list.begin(), list.end());
650+
#else
651+
// support older versions where deprecation warning is not fatal
652+
mCollapsedItemIds = QSet<QString>::fromList(list);
653+
#endif
649654
}
650655

651656
void TailoringWindow::serializeCollapsedItems()
@@ -657,7 +662,12 @@ void TailoringWindow::serializeCollapsedItems()
657662
}
658663
else
659664
{
660-
mQSettings->setValue(getQSettingsKey(), QVariant(mCollapsedItemIds.toList()));
665+
#if (QT_VERSION >= QT_VERSION_CHECK(5, 14, 0))
666+
mQSettings->setValue(getQSettingsKey(), QVariant(mCollapsedItemIds.values()));
667+
#else
668+
// support older versions where deprecation warning is not fatal
669+
mQSettings->setValue(getQSettingsKey(), QVariant(mCollapsedItemIds.toList()));
670+
#endif
661671
mQSettings->setValue(getQSettingsKey() + "_lastUsed", QVariant(QDateTime::currentDateTime()));
662672
}
663673
}

0 commit comments

Comments
 (0)