Fix strange "error":null JSON node

bogdan-iancu · bogdan-iancu · commit 1a8f8e47bf3b · 2023-04-10T15:13:11.000+03:00
An `error` node with NULL value does not make much of a sense, but let's try to handle it. Closes #3047
diff --git a/modules/jsonrpc/jsonrpc.c b/modules/jsonrpc/jsonrpc.c
@@ -339,7 +339,7 @@ static int jsonrpc_handle_cmd(union sockaddr_union *dst, char *cmd, int *id,
 	}
 
 	aux = cJSON_GetObjectItem(obj, "error");
-	if (aux) {
+	if (aux && aux->type!=cJSON_NULL) {
 		/* return the entire error */
 		vret->rs.s = cJSON_Print(aux);
 		vret->rs.len = strlen(vret->rs.s);

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ static int jsonrpc_handle_cmd(union sockaddr_union dst, char cmd, int *id,`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`aux = cJSON_GetObjectItem(obj, "error");`
`342`		`- if (aux) {`
	`342`	`+ if (aux && aux->type!=cJSON_NULL) {`
`343`	`343`	`/* return the entire error */`
`344`	`344`	`vret->rs.s = cJSON_Print(aux);`
`345`	`345`	`vret->rs.len = strlen(vret->rs.s);`