acc: Improve oom handling

liviuchircu · liviuchircu · commit 86ef10af2cba · 2020-03-24T18:25:32.000+02:00
Do not populate bogus str values (e.g. {NULL, 3}) when out of SHM and
setting $acc_extra.
diff --git a/modules/acc/acc_vars.c b/modules/acc/acc_vars.c
@@ -165,8 +165,10 @@ int set_value_shm(pv_value_t* pvt, extra_value_t* extra)
 			extra->value.len = s.len;
 		}
 
-		if (extra->value.s == NULL)
+		if (extra->value.s == NULL) {
+			extra->shm_buf_len = extra->value.len = 0;
 			goto memerr;
+		}
 
 		memcpy(extra->value.s, s.s, s.len);
 	}

Original file line number	Diff line number	Diff line change
`@@ -165,8 +165,10 @@ int set_value_shm(pv_value_t* pvt, extra_value_t* extra)`
`165`	`165`	`extra->value.len = s.len;`
`166`	`166`	`}`
`167`	`167`
`168`		`- if (extra->value.s == NULL)`
	`168`	`+ if (extra->value.s == NULL) {`
	`169`	`+ extra->shm_buf_len = extra->value.len = 0;`
`169`	`170`	`goto memerr;`
	`171`	`+ }`
`170`	`172`
`171`	`173`	`memcpy(extra->value.s, s.s, s.len);`
`172`	`174`	`}`