auth: return -1 on error in auth_get_ha1()

l2dy · l2dy · commit 96fcb5f9fd95 · 2020-03-14T05:17:35.000Z
diff --git a/modules/auth/auth_mod.c b/modules/auth/auth_mod.c
@@ -393,7 +393,7 @@ static inline int auth_get_ha1(struct sip_msg *msg, struct username* _username,
 			return 1;
 		}
 	} else {
-		return 1;
+		return -1;
 	}
 	/* get password from PV */
 	memset(&sval, 0, sizeof(pv_value_t));
@@ -406,7 +406,7 @@ static inline int auth_get_ha1(struct sip_msg *msg, struct username* _username,
 			return 1;
 		}
 	} else {
-		return 1;
+		return -1;
 	}
 	if (auth_calc_ha1) {
 		/* Only plaintext passwords are stored in database,

Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ static inline int auth_get_ha1(struct sip_msg msg, struct username _username,`
`393`	`393`	`return 1;`
`394`	`394`	`}`
`395`	`395`	`} else {`
`396`		`- return 1;`
	`396`	`+ return -1;`
`397`	`397`	`}`
`398`	`398`	`/* get password from PV */`
`399`	`399`	`memset(&sval, 0, sizeof(pv_value_t));`
`@@ -406,7 +406,7 @@ static inline int auth_get_ha1(struct sip_msg msg, struct username _username,`
`406`	`406`	`return 1;`
`407`	`407`	`}`
`408`	`408`	`} else {`
`409`		`- return 1;`
	`409`	`+ return -1;`
`410`	`410`	`}`
`411`	`411`	`if (auth_calc_ha1) {`
`412`	`412`	`/* Only plaintext passwords are stored in database,`