Skip to content

Commit 9f18454

Browse files
event_kafka: fix syntax errors
Related to commit d69a8cc
1 parent c05cb75 commit 9f18454

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

modules/event_kafka/event_kafka.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -759,7 +759,7 @@ static int kafka_publish(struct sip_msg *sip_msg, kafka_broker_t *broker,
759759
job->data = (void*)((char *)(job + 1) + msg->len + key->len);
760760
((script_job_data_t *)job->data)->broker = broker;
761761
((script_job_data_t *)job->data)->report_rt = report_rt==NULL ? NULL :
762-
dup_ref_script_route_in_shm((struct script_route_ref *ref)report_rt,0);
762+
dup_ref_script_route_in_shm((struct script_route_ref *)report_rt,0);
763763

764764
if (kafka_send_job(job) < 0) {
765765
LM_ERR("cannot send job to worker\n");

modules/event_kafka/kafka_producer.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -377,18 +377,23 @@ void kafka_report_status(int sender, void *param)
377377
{
378378
struct kafka_report_param *p =
379379
(struct kafka_report_param *)param;
380+
script_job_data_t *job_data;
380381

381382
if (p->job->type == KAFKA_JOB_EVI) {
382383
evi_job_data_t *job_data = (evi_job_data_t *)p->job->data;
383384

384385
job_data->evi_async_ctx.status_cb(job_data->evi_async_ctx.cb_param,
385386
p->status);
386-
} else if (ref_script_route_check_and_update(job_data->report_rt)) {
387-
script_job_data_t *job_data = (script_job_data_t *)p->job->data;
387+
} else {
388388
struct sip_msg *req;
389389
struct usr_avp **old_avps;
390390
struct usr_avp *report_avps;
391391

392+
job_data = (script_job_data_t *)p->job->data;
393+
394+
if (!ref_script_route_check_and_update(job_data->report_rt))
395+
goto free;
396+
392397
req = get_dummy_sip_msg();
393398
if (!req) {
394399
LM_ERR("Failed to get DUMMY SIP msg\n");
@@ -412,7 +417,7 @@ void kafka_report_status(int sender, void *param)
412417
}
413418

414419
free:
415-
if (job_data->report_rt)
420+
if (p->job->type == KAFKA_JOB_SCRIPT && job_data->report_rt)
416421
shm_free(job_data->report_rt);
417422
shm_free(p->job);
418423
shm_free(p);

0 commit comments

Comments
 (0)