rtp_relay: fix broken ref taken with lock

razvancrainea · razvancrainea · commit aae8b39b5779 · 2024-01-04T05:42:18.000+02:00
This caused a deadlock when DLG registers were not able to be setup.
diff --git a/modules/rtp_relay/rtp_relay_ctx.c b/modules/rtp_relay/rtp_relay_ctx.c
@@ -1706,7 +1706,7 @@ static int rtp_relay_sess_success(struct rtp_relay_ctx *ctx,
 
 		if (rtp_relay_dlg_callbacks(dlg, ctx, to_tag) < 0) {
 			/* restore the state */
-			RTP_RELAY_CTX_REF(ctx);
+			RTP_RELAY_CTX_REF_UNSAFE(ctx, 1);
 			RTP_RELAY_PUT_TM_CTX(t, ctx);
 			return -1;
 		}

Original file line number	Diff line number	Diff line change
`@@ -1706,7 +1706,7 @@ static int rtp_relay_sess_success(struct rtp_relay_ctx *ctx,`
`1706`	`1706`
`1707`	`1707`	`if (rtp_relay_dlg_callbacks(dlg, ctx, to_tag) < 0) {`
`1708`	`1708`	`/* restore the state */`
`1709`		`- RTP_RELAY_CTX_REF(ctx);`
	`1709`	`+ RTP_RELAY_CTX_REF_UNSAFE(ctx, 1);`
`1710`	`1710`	`RTP_RELAY_PUT_TM_CTX(t, ctx);`
`1711`	`1711`	`return -1;`
`1712`	`1712`	`}`