sql_cacher: fix SQL result leak when insert_in_cachedb fails

benceszigeti · benceszigeti · commit d373ab65ff0b · 2024-01-23T14:06:41.000+01:00
diff --git a/modules/sql_cacher/sql_cacher.c b/modules/sql_cacher/sql_cacher.c
@@ -964,7 +964,7 @@ static int load_entire_table(cache_entry_t *c_entry, db_handlers_t *db_hdls,
 				if (insert_in_cachedb(c_entry, db_hdls, values ,values + 1,
 					reload_vers, ROW_N(row) - 1) < 0) {
 					lock_stop_write(db_hdls->c_entry->ref_lock);
-					return -1;
+					goto error;
 				}
 				loaded_rec++;
 			}

Original file line number	Diff line number	Diff line change
`@@ -964,7 +964,7 @@ static int load_entire_table(cache_entry_t c_entry, db_handlers_t db_hdls,`
`964`	`964`	`if (insert_in_cachedb(c_entry, db_hdls, values ,values + 1,`
`965`	`965`	`reload_vers, ROW_N(row) - 1) < 0) {`
`966`	`966`	`lock_stop_write(db_hdls->c_entry->ref_lock);`
`967`		`- return -1;`
	`967`	`+ goto error;`
`968`	`968`	`}`
`969`	`969`	`loaded_rec++;`
`970`	`970`	`}`