CacheDB: Allow "," in URL passwords

Many thanks to @xuxin010033 for the report!

Fixes #2786

Author: liviuchircu

cachedb/cachedb_id.c

@@ -210,6 +210,10 @@ static int parse_cachedb_url(struct cachedb_id* id, const str* url)
 				break;
 
 			case ',':
+				/* password could have a "," -> do a look-ahead to confirm */
+				if (q_memchr(url->s + i, '@', len - i))
+					continue;
+
 				st=ST_HOST;
 				start_host=start_prev;
 				id->flags |= CACHEDB_ID_MULTIPLE_HOSTS;

cachedb/test/test_cachedb.c

@@ -694,6 +694,7 @@ static void test_cachedb_url(void)
 	/* invalid URLs */
 	ok(!new_cachedb_id(_str("d:g://@")));
 	ok(!new_cachedb_id(_str("d:g://u:@")));
+	ok(!new_cachedb_id(_str("d:g://u:p")));
 	ok(!new_cachedb_id(_str("d:g://u:p@")));
 	ok(!new_cachedb_id(_str("d:g://u:p@h:")));
 
@@ -875,4 +876,14 @@ static void test_cachedb_url(void)
 	ok(!strcmp(db->host, "h1,h2,h3:6379"));
 	ok(!strcmp(db->database, "d"));
 	ok(db->port == 0);
+
+	/* special chars in password */
+
+	CDB_PARSE("redis:group1://:,pwd,foo,@h1,h2,h3:6379/d");
+	ok(db->flags == CACHEDB_ID_MULTIPLE_HOSTS);
+	ok(!strcmp(db->username, ""));
+	ok(!strcmp(db->password, ",pwd,foo,"));
+	ok(!strcmp(db->host, "h1,h2,h3:6379"));
+	ok(!strcmp(db->database, "d"));
+	ok(db->port == 0);
 }