Unable to build without Makefile modification on Linux

[EmperorArthur]

Unfortunately, the Makefile includes BSD only dependencies which do not work in Linux environments.
One example is:

.include <bsd.subdir.mk>

On Linux make spits out an error of:

Makefile:3: *** missing separator. Stop.

I'll probably fix this tomorrow, but the big question is what's the best way to go about it? I don't know what's in the BSD included files. The two options that immediately spring to mind are just write simple 'all' and 'install' targets or to add either Cmake or Meson as a build system.

Personally I think Meson looks like the easy approach, since the resulting file would probably be under 10 lines, and that's counting the installation. However, it adds an additional build dependency, and requires an additional command to generate the Makefile. That's not a problem for my use case since Alpine Linux has a Meson in it's package manager, but may be an issue for BSD builds.

[poolpOrg]

@ericfaurot is away for the week, I'll have a chat about him with regard to this, maybe smtpscript should be integrated with the OpenSMTPD project to make it more easily available.

it's been developed as an external tool which is why it is in its own repository, but we can definitely challenge that decision.

[EmperorArthur]

Sounds good. Either way works for me, but being in the main repository will speed up the CI system by a few seconds per run.

The big question is if any other mail server is using smtpscript, or if it's just OpenSMTPD. Based on this issue, my guess is if they are they're on a BSD system. Which makes it rather unlikely.

I will hold off on making any changes until @ericfaurot gets back. There's no rush since what we have does work for at least some regression testing.

[poolpOrg]

Discussed with @ericfaurot on the phone today and convinced him smtpscript should be merged to the OpenSMTPD portable repository in the short term and possibly to the smtp utility in both native and portable branch in the long term.

Will take care of moving smtpscript to OpenSMTPD this week-end unless you beat me to it.

[poolpOrg]

Hello,

Sorry for the delay, it turns out my first attempt wasn't successful and I got context switched out of computers for ten days...

Anyways, back to it, my plan is to create an smtpscript/ directory in the OpenSMTPD checkout so that master branch can build as is, whereas portable branch can put the autotools glue where appropriate.

will close this ticket when i'm done.

EDIT:
brought the smtpscript code to the OpenSMTPD repository, for the master branch we're done, however for the portable branch a bit of plumbing is necessary to add a proper Makefile.am in mk/ and to ensure it is plugged correctly so we can conditionally build it if configure is ran with --with-smtpscript

[EmperorArthur]

No worries on my end. I got caught up on an unrelated hardware project myself, and haven't had the chance to look at it.