Merge pull request #482 from OpenSPP/fix-indicator-duplicate

Fixed duplicate checkbox in the additional details; added test case

Author: gonzalesedwin1123

spp_custom_field/models/cus_partner.py

@@ -28,9 +28,6 @@ def create_field_element(self, div_element, model_field_id, is_ind=False):
             sub_element_params = {
                 "name": model_field_id.name,
             }
-            if is_ind:
-                sub_element_params["readonly"] = "1"
-                sub_element_params["class"] = "oe_read_only"
             new_field = etree.SubElement(
                 div_element_left,
                 "field",
@@ -42,9 +39,6 @@ def create_field_element(self, div_element, model_field_id, is_ind=False):
                 span = etree.SubElement(div_element_right_help, "span")
                 span.text = model_field_id.help
 
-            div_element_right_inner_div = etree.SubElement(div_element_right, "div", {"class": "text-muted"})
-            new_field = etree.SubElement(div_element_right_inner_div, "field", {"name": model_field_id.name})
-
         else:
             etree.SubElement(div_element_right, "label", {"for": model_field_id.name})
 
@@ -82,8 +76,8 @@ def _get_view(self, view_id=None, view_type="form", **options):
                     action_id = action_id.context.replace("'", '"')
                 is_group = ast.literal_eval(action_id).get("default_is_group")
 
-                custom_page = etree.Element("page", {"string": "Additional Details"})
-                indicators_page = etree.Element("page", {"string": "Indicators"})
+                custom_page = etree.Element("page", {"string": "Additional Details", "name": "additional_details"})
+                indicators_page = etree.Element("page", {"string": "Indicators", "name": "indicators"})
 
                 custom_div = etree.SubElement(custom_page, "div", {"class": "row mt16 o_settings_container"})
                 indicators_div = etree.SubElement(indicators_page, "div", {"class": "row mt16 o_settings_container"})

spp_demo/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_cus_partner

spp_demo/tests/test_cus_partner.py

@@ -0,0 +1,32 @@
+from odoo.tests.common import TransactionCase
+
+
+class TestOpenSPPResPartnerCustom(TransactionCase):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.view_group_id = cls.env.ref("g2p_registry_group.view_groups_form").id
+        cls.view_group_action_id = cls.env.ref("g2p_registry_group.action_groups_list").id
+
+        cls.view_individual_id = cls.env.ref("g2p_registry_individual.view_individuals_form").id
+        cls.view_individual_action_id = cls.env.ref("g2p_registry_individual.action_individuals_list").id
+
+    def test_get_view_group(self):
+        options = {"action_id": self.view_group_action_id, "load_filters": True, "toolbar": True}
+        arch, view = self.env["res.partner"]._get_view(self.view_group_id, "form", **options)
+
+        self.assertEqual(len(arch.xpath("//page[@name='indicators']")), 1)
+        self.assertEqual(len(arch.xpath("//page[@name='additional_details']")), 0)
+
+    def test_get_view_individual(self):
+        options = {"action_id": self.view_individual_action_id, "load_filters": True, "toolbar": True}
+        arch, view = self.env["res.partner"]._get_view(self.view_individual_id, "form", **options)
+
+        self.assertEqual(len(arch.xpath("//page[@name='indicators']")), 0)
+        self.assertEqual(len(arch.xpath("//page[@name='additional_details']")), 1)
+
+    def test_get_view_no_options(self):
+        arch, view = self.env["res.partner"]._get_view(self.view_individual_id, "form")
+
+        self.assertEqual(len(arch.xpath("//page[@name='indicators']")), 0)
+        self.assertEqual(len(arch.xpath("//page[@name='additional_details']")), 1)