spp_branding_kit: remove obsolete settings fields and tests; update readme keys; clean Apps view context usage

Author: jeremi

spp_branding_kit/models/res_config_settings.py

@@ -58,22 +58,4 @@ class ResConfigSettings(models.TransientModel):
         config_parameter="openspp.ui.hide_odoo_referral",
     )
 
-    openspp_hide_paid_apps = fields.Boolean(
-        "Hide Paid Apps",
-        help="Hide paid Odoo apps (Enterprise and OPL licensed modules) from the Apps list",
-        default=True,
-        config_parameter="openspp.hide_paid_apps",
-    )
-
-    openspp_default_app_filter = fields.Selection(
-        [
-            ("all", "All Modules"),
-            ("apps_only", "Apps Only"),
-            ("openspp", "OpenSPP Apps Only"),
-            ("free", "Free Apps Only"),
-        ],
-        string="Default Apps Filter",
-        help="Choose which modules to show by default in the Apps menu",
-        default="apps_only",
-        config_parameter="openspp.default_app_filter",
-    )
+    # Apps filtering is now handled in the UI via default search filters.

spp_branding_kit/readme/DESCRIPTION.md

@@ -69,12 +69,11 @@ The **OpenSPP Branding Kit** module is designed to:
 
 The module provides various configuration parameters that can be adjusted through the Settings interface or directly via system parameters:
 
-* `openspp.system_name`: Custom system name displayed throughout the interface
-* `openspp.hide_paid_apps`: Toggle to hide paid applications from the Apps menu
-* `openspp.telemetry_enabled`: Enable or disable telemetry data collection
-* `openspp.documentation_url`: Custom documentation URL for help links
-* `openspp.support_url`: Custom support URL for assistance
+* `openspp.system.name`: Custom system name displayed throughout the interface
+* `openspp.telemetry.enabled`: Enable or disable telemetry data collection
+* `openspp.documentation.url`: Custom documentation URL for help links
+* `openspp.support.url`: Custom support URL for assistance
 
 ## Conclusion
 
-The **OpenSPP Branding Kit** module provides a complete solution for transforming an Odoo 17 installation into a fully branded OpenSPP platform. It ensures consistent branding across all interfaces while maintaining system functionality and providing administrators with granular control over branding and behavior settings. The module's modular architecture and adherence to Odoo best practices ensure compatibility with future updates and seamless integration with other OpenSPP modules.
+The **OpenSPP Branding Kit** module provides a complete solution for transforming an Odoo 17 installation into a fully branded OpenSPP platform. It ensures consistent branding across all interfaces while maintaining system functionality and providing administrators with granular control over branding and behavior settings. The module's modular architecture and adherence to Odoo best practices ensure compatibility with future updates and seamless integration with other OpenSPP modules.

spp_branding_kit/tests/__init__.py

@@ -1,7 +1,6 @@
 # ABOUTME: Test module initialization
 # ABOUTME: Import test cases for spp_branding_kit module
 
-from . import test_hide_paid_apps
 from . import test_init_hooks
 from . import test_controllers
 from . import test_models

spp_branding_kit/views/ir_module_module_views.xml

@@ -47,10 +47,8 @@
                 <filter
                     name="paid_apps"
                     string="Paid Apps"
-                    domain="['|', ('license', '=like', 'OEEL%'),
-                                     ('license', '=like', 'OPL%')]"
+                    domain="['|', ('license', '=like', 'OEEL%'), ('license', '=like', 'OPL%')]"
                     help="Show paid/proprietary apps"
-                    invisible="context.get('hide_paid_apps_enabled', False)"
                 />
             </filter>
         </field>