Fixed error in DMS and Change Request integration

Author: gonzalesedwin1123

spp_change_request/data/dms.xml

@@ -4,7 +4,23 @@ Part of OpenSPP. See LICENSE file for full copyright and licensing details.
 -->
 <odoo noupdate="0">
 
-    <!-- Parent Category -->
+    <!-- Common Categories -->
+    <record id="spp_dms_birth_certificate" model="spp.dms.category">
+        <field name="name">Birth Certificate</field>
+    </record>
+
+    <record id="spp_dms_applicant_uid_card" model="spp.dms.category">
+        <field name="name">Applicant UID Card</field>
+    </record>
+
+    <record id="spp_dms_custody_certificate" model="spp.dms.category">
+        <field name="name">Custody Certificate</field>
+    </record>
+
+    <record id="spp_dms_uid_card" model="spp.dms.category">
+        <field name="name">UID Card</field>
+    </record>
+
     <record id="pds_dms_extra_documents" model="spp.dms.category">
         <field name="name">Extra Documents</field>
     </record>

spp_change_request/models/change_request.py

@@ -680,8 +680,7 @@ def create_request_detail(self):
                 # Set the request_type_ref_id
                 res_model = rec.request_type
                 # Set the dms directory
-                _logger.info("Change Request: DMS Directory Creation (%s)" % len(self.dms_directory_ids))
-                self.env.ref(self.env[res_model].DMS_STORAGE)
+                _logger.info("Change Request: DMS Directory Creation (%s)" % len(rec.dms_directory_ids))
                 dmsval = {
                     "is_root_directory": True,
                     "name": rec.name,
@@ -935,8 +934,8 @@ def _compute_validation_group_id(self):
 
                 validation_stages = (
                     rec.request_type_ref_id.validation_ids
-                    # if rec.request_type_ref_id and rec.request_type_ref_id.validation_ids
-                    # else self.env["validation.model"].browse()
+                    if rec.request_type_ref_id and rec.request_type_ref_id.validation_ids
+                    else self.env["spp.change.request.validation.sequence"].browse()
                 )  # Replace 'validation.model' with the actual model name
 
                 # Filter validation_stages based on validation_stage_ids, if any

spp_change_request/models/mixins/source_mixin.py

@@ -35,9 +35,8 @@ class ChangeRequestAddChildren(models.Model):
     _description = "Change Request Data Source Mixin"
     _rec_name = "change_request_id"
 
-    REQUIRED_DOCUMENT_TYPE = []  # List of required document category `dms.category`
+    REQUIRED_DOCUMENT_TYPE = []  # List of required document category `spp.dms.category`
     VALIDATION_FORM = None
-    DMS_STORAGE = None
     AUTO_APPLY_CHANGES = True
 
     registrant_id = fields.Many2one("res.partner", "Registrant", domain=[("is_registrant", "=", True)])
@@ -814,13 +813,13 @@ def action_attach_documents(self):
                     "view_mode": "form",
                     "view_id": form_id,
                     "view_type": "form",
-                    "res_model": "dms.file",
+                    "res_model": "spp.dms.file",
                     "target": "new",
                     "context": dms_context,
                 }
                 if self.env.context.get("category_id"):
                     category_id = self.env.context.get("category_id")
-                    category = self.env["dms.category"].search([("id", "=", category_id)])
+                    category = self.env["spp.dms.category"].search([("id", "=", category_id)])
                     if category:
                         dms_context.update(
                             {

spp_change_request_add_children_demo/data/dms.xml

@@ -1,25 +1,9 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo noupdate="0">
 
-    <!-- Child Category Documents-->
+    <!-- Category Documents-->
     <record id="spp_dms_add_children" model="spp.dms.category">
         <field name="name">Add Children Request Form</field>
     </record>
 
-    <record id="spp_dms_birth_certificate" model="spp.dms.category">
-        <field name="name">Birth Certificate</field>
-    </record>
-
-    <record id="spp_dms_applicant_uid_card" model="spp.dms.category">
-        <field name="name">Applicant UID Card</field>
-    </record>
-
-    <record id="spp_dms_custody_certificate" model="spp.dms.category">
-        <field name="name">Custody Certificate</field>
-    </record>
-
-    <record id="spp_dms_uid_card" model="spp.dms.category">
-        <field name="name">UID Card</field>
-    </record>
-
 </odoo>

spp_change_request_add_children_demo/models/change_request_add_children.py

@@ -36,15 +36,14 @@ class ChangeRequestAddChildren(models.Model):
     _description = "Add Child/Member Change Request Type"
     _order = "id desc"
 
-    # Initialize DMS Storage
-    DMS_STORAGE = "spp_change_request_add_children_demo.attachment_storage_add_children"
+    # Initialize CR constants
     VALIDATION_FORM = "spp_change_request_add_children_demo.view_change_request_add_children_validation_form"
     REQUIRED_DOCUMENT_TYPE = [
-        # "spp_change_request_add_children_demo.spp_dms_add_children",
-        # "spp_change_request_add_children_demo.spp_dms_birth_certificate",
-        # "spp_change_request_add_children_demo.spp_dms_applicant_spp_card",
-        # "spp_change_request_add_children_demo.spp_dms_applicant_uid_card",
-        # "spp_change_request_add_children_demo.spp_dms_custody_certificate",
+        "spp_change_request_add_children_demo.spp_dms_add_children",
+        # "spp_change_request.spp_dms_birth_certificate",
+        # "spp_change_request.spp_dms_applicant_spp_card",
+        # "spp_change_request.spp_dms_applicant_uid_card",
+        # "spp_change_request.spp_dms_custody_certificate",
     ]
 
     # Mandatory initialize source and destination center areas

spp_change_request_add_children_demo/views/change_request_add_children_view.xml

@@ -224,23 +224,23 @@
                                 </group>
                             </group>
                         </page>
-                        <page string="Attachments" invisible="1">
+                        <page string="Attachments">
                             <!-- Attachment UI -->
                             <header invisible="state != 'draft'">
-                                <!-- <button
+                                <button
                                     name="action_attach_documents"
                                     type="object"
                                     string="Request Form"
                                     class="btn-primary"
                                     context="{'category_id':%(spp_dms_add_children)d}"
                                     style="margin-left: 10px;"
-                                /> -->
+                                />
                                 <button
                                     name="action_attach_documents"
                                     type="object"
                                     string="Birth Certificate"
                                     class="btn-primary"
-                                    context="{'category_id':%(spp_dms_birth_certificate)d}"
+                                    context="{'category_id':%(spp_change_request.spp_dms_birth_certificate)d}"
                                     style="margin-left: 10px;"
                                 />
                                 <button