fix(spp_branding_kit): resolve XPath conflicts with g2p_theme module

- Replace problematic XPath selectors with CSS-based approach
- Add login_branding.css to handle Odoo branding removal
- Simplify login_templates.xml to avoid template inheritance conflicts
- Move branding logic from XML to frontend assets for better compatibility

Fixes build failures caused by missing elements in different environments.

Author: jeremi

spp_branding_kit/__manifest__.py

@@ -54,6 +54,9 @@
             "spp_branding_kit/static/src/js/telemetry_manager.js",
             "spp_branding_kit/static/src/js/apps_filter.js",
         ],
+        "web.assets_frontend": [
+            "spp_branding_kit/static/src/css/login_branding.css",
+        ],
     },
     "images": [
         "static/description/icon.png",

spp_branding_kit/static/src/css/login_branding.css

@@ -0,0 +1,39 @@
+/* ABOUTME: CSS for OpenSPP branding on login pages */
+/* ABOUTME: Hides Odoo branding and adds OpenSPP branding */
+
+/* Hide any existing Odoo branding */
+a[href*="odoo.com"] {
+    display: none !important;
+}
+
+.o_footer_copyright a[href*="odoo.com"] {
+    display: none !important;
+}
+
+footer a[href*="odoo.com"] {
+    display: none !important;
+}
+
+/* Hide "Manage Databases" link */
+a[href="/web/database/manager"] {
+    display: none !important;
+}
+
+/* Add OpenSPP branding */
+body::after {
+    content: "Powered by OpenSPP";
+    position: fixed;
+    bottom: 10px;
+    left: 50%;
+    transform: translateX(-50%);
+    color: #777;
+    font-size: 12px;
+    z-index: 1000;
+    pointer-events: none;
+}
+
+/* Ensure footer is visible when present */
+.oe_login_form ~ footer,
+.o_database_list ~ footer {
+    display: block !important;
+}

spp_branding_kit/views/login_templates.xml

@@ -2,22 +2,14 @@
 <!-- ABOUTME: Login page templates for OpenSPP branding -->
 <!-- ABOUTME: Customizes the login interface with OpenSPP branding -->
 <odoo>
-        <!-- Custom Login Page Layout -->
+        <!-- Custom Login Page Layout - Minimal override -->
         <template
         id="custom_login_layout_openspp"
         inherit_id="web.login_layout"
         name="OpenSPP Custom Login Layout"
-        priority="99"
+        priority="100"
     >
-            <!-- Replace "Powered by Odoo" in login footer -->
-            <xpath expr="//a[contains(@href, 'www.odoo.com')]" position="replace">
-                <span>Powered by OpenSPP</span>
-            </xpath>
-
-            <!-- Remove "Manage Databases" link if configured -->
-            <xpath expr="//a[@href='/web/database/manager']" position="attributes">
-                <attribute name="class" add="d-none" separator=" " />
-            </xpath>
+            <!-- Only override g2p_theme's no_footer setting - branding handled via CSS assets -->
         </template>