fix(spp_branding_kit): remove debug mode restriction to fix singleton error

Remove the debug mode admin-only restriction feature from the branding module
as it was causing "Expected singleton: res.users()" errors when accessing
/web?debug=1 without authentication. This feature doesn't belong in a
branding module and should be handled by proper security/access controls.

Changes:
- Remove debug mode check from web_client controller method
- Remove openspp_debug_admin_only field from settings model
- Remove debug mode setting from configuration UI
- Remove debug_admin_only from session info
- Update documentation to reflect removed feature

Author: jeremi

spp_branding_kit/controllers/main.py

@@ -14,19 +14,7 @@ class OpenSPPHome(Home):
 
     @http.route()
     def web_client(self, s_action=None, **kw):
-        """Override web client to enforce debug mode restrictions"""
-        # Check if debug mode is restricted to admins BEFORE rendering
-        if kw.get("debug", False):
-            config_parameter = request.env["ir.config_parameter"].sudo()
-            debug_admin_only = config_parameter.get_param("openspp.debug_admin_only", "True") == "True"
-
-            if debug_admin_only and request.session.uid:
-                # Check if current user is admin
-                if not request.env.user._is_admin():
-                    # Remove debug parameter and redirect
-                    kw.pop("debug", None)
-                    return request.redirect("/web", 303)
-
+        """Override web client for branding"""
         return super().web_client(s_action, **kw)
 
 

spp_branding_kit/models/ir_http.py

@@ -30,7 +30,6 @@ def session_info(self):
                 "openspp_telemetry_endpoint": IrConfig.get_param(
                     "openspp.telemetry_endpoint", "https://telemetry.openspp.org"
                 ),
-                "openspp_debug_admin_only": IrConfig.get_param("openspp.debug_admin_only", "True") == "True",
             }
         )
 

spp_branding_kit/models/res_config_settings.py

@@ -51,13 +51,6 @@ class ResConfigSettings(models.TransientModel):
         config_parameter="openspp.telemetry_endpoint",
     )
 
-    openspp_debug_admin_only = fields.Boolean(
-        "Admin-Only Debug Mode",
-        help="Limit debug mode access to administrators",
-        default=True,
-        config_parameter="openspp.debug_admin_only",
-    )
-
     openspp_hide_odoo_referral = fields.Boolean(
         "OpenSPP Interface Mode",
         help="Optimize interface for OpenSPP-specific workflows",

spp_branding_kit/readme/DESCRIPTION.md

@@ -9,7 +9,7 @@ The **OpenSPP Branding Kit** module is designed to:
 * **Apply OpenSPP Branding**: Replace removed Odoo branding with OpenSPP-specific branding elements, including logos, colors, text, and system information.
 * **Control Telemetry and External Communications**: Provide administrators with control over telemetry data collection and external service communications.
 * **Hide Paid Applications**: Optionally filter out enterprise and paid Odoo applications from the Apps menu to focus on open-source modules.
-* **Customize System Behavior**: Offer configuration options for debug mode access, system naming, documentation URLs, and support links.
+* **Customize System Behavior**: Offer configuration options for system naming, documentation URLs, and support links.
 
 ## Dependencies and Integration
 
@@ -23,15 +23,14 @@ The **OpenSPP Branding Kit** module is designed to:
 * **Configuration Management ([ir.config_parameter](ir.config_parameter))**:
     * Introduces system-wide configuration parameters with the `openspp.*` prefix for centralized branding control.
     * Provides settings for system name, documentation URLs, support links, and telemetry endpoints.
-    * Enables toggle options for features like hiding paid apps and restricting debug mode access.
+    * Enables toggle options for features like hiding paid apps.
 
 * **Module Filtering ([ir.module.module](ir.module.module))**:
     * Implements intelligent filtering of paid applications (OEEL and OPL licensed modules) from the Apps menu.
     * Maintains visibility of paid modules in administrative views while hiding them from the standard Apps interface.
     * Provides helper methods for counting and filtering paid applications.
 
 * **Web Interface Customization**:
-    * Customizes the web client to enforce debug mode restrictions based on user permissions.
     * Provides custom routes for OpenSPP-specific information pages.
     * Modifies session information to include OpenSPP branding data.
     * Implements telemetry redirection to OpenSPP endpoints when enabled.
@@ -50,7 +49,6 @@ The **OpenSPP Branding Kit** module is designed to:
 * **Security and Privacy Features**:
     * Disables unnecessary telemetry and external communications by default.
     * Removes promotional content and enterprise upselling elements.
-    * Provides administrator-only debug mode option for enhanced security.
     * Implements proper permission controls for branding configuration.
 
 ## Module Components
@@ -73,7 +71,6 @@ The module provides various configuration parameters that can be adjusted throug
 
 * `openspp.system_name`: Custom system name displayed throughout the interface
 * `openspp.hide_paid_apps`: Toggle to hide paid applications from the Apps menu
-* `openspp.debug_admin_only`: Restrict debug mode access to administrators only
 * `openspp.telemetry_enabled`: Enable or disable telemetry data collection
 * `openspp.documentation_url`: Custom documentation URL for help links
 * `openspp.support_url`: Custom support URL for assistance

spp_branding_kit/views/res_config_settings_views.xml

@@ -52,12 +52,6 @@
                             />
                         </setting>
                     </block>
-
-                    <block title="Security" name="openspp_security_block">
-                        <setting help="Limit debug mode access to system administrators">
-                            <field name="openspp_debug_admin_only" />
-                        </setting>
-                    </block>
                 </app>
             </xpath>
         </field>