Fix clippy

Author: OpenSauce

src/sim/chain.rs

@@ -189,6 +189,7 @@ pub fn create_mesa_boogie_dual_rectifier(sample_rate: f32) -> AmplifierChain {
 
 // AmplifierChain implementation that holds and processes all stages
 pub struct AmplifierChain {
+    #[allow(dead_code)]
     name: String,
     stages: Vec<Box<dyn Stage + Send>>,
     active_channel: usize,                // 0, 1, or 2 for clean, rhythm, lead

src/sim/stages/mod.rs

@@ -10,12 +10,15 @@ pub trait Stage: Send {
     // Process a single sample through this stage
     fn process(&mut self, input: f32) -> f32;
 
+    #[allow(dead_code)]
     // Set a parameter value by name
     fn set_parameter(&mut self, name: &str, value: f32) -> Result<(), &'static str>;
 
+    #[allow(dead_code)]
     // Get a parameter value by name
     fn get_parameter(&self, name: &str) -> Result<f32, &'static str>;
 
+    #[allow(dead_code)]
     // Get the name of this stage
     fn name(&self) -> &str;
 }

src/sim/stages/poweramp.rs

@@ -90,15 +90,15 @@ impl Stage for PowerAmpStage {
     fn set_parameter(&mut self, name: &str, value: f32) -> Result<(), &'static str> {
         match name {
             "drive" => {
-                if value >= 0.0 && value <= 1.0 {
+                if (0.0..=1.0).contains(&value) {
                     self.drive = value;
                     Ok(())
                 } else {
                     Err("Drive must be between 0.0 and 1.0")
                 }
             }
             "sag" => {
-                if value >= 0.0 && value <= 1.0 {
+                if (0.0..=1.0).contains(&value) {
                     self.sag = value;
                     Ok(())
                 } else {

src/sim/stages/preamp.rs

@@ -34,15 +34,14 @@ impl Stage for PreampStage {
     fn set_parameter(&mut self, name: &str, value: f32) -> Result<(), &'static str> {
         match name {
             "gain" => {
-                if value >= 0.0 && value <= 10.0 {
-                    self.gain = value;
+                if (0.0..=10.0).contains(&value) {
                     Ok(())
                 } else {
                     Err("Gain must be between 0.0 and 10.0")
                 }
             }
             "bias" => {
-                if value >= -1.0 && value <= 1.0 {
+                if (-1.0..=1.0).contains(&value) {
                     self.bias = value;
                     Ok(())
                 } else {

src/sim/stages/tonestack.rs

@@ -69,10 +69,13 @@ impl Stage for ToneStackStage {
             ToneStackModel::Flat => (100.0, 800.0, 2000.0, 5000.0),   // Neutral
         };
 
-        // Calculate filter coefficients (simplified)
+        // Calculate filter coefficients
         let bass_alpha =
             (1.0 / self.sample_rate) / ((1.0 / (2.0 * PI * bass_freq)) + (1.0 / self.sample_rate));
 
+        let mid_alpha = (1.0 / (2.0 * PI * mid_freq))
+            / ((1.0 / (2.0 * PI * mid_freq)) + (1.0 / self.sample_rate));
+
         let treble_alpha = (1.0 / (2.0 * PI * treble_freq))
             / ((1.0 / (2.0 * PI * treble_freq)) + (1.0 / self.sample_rate));
 
@@ -82,9 +85,9 @@ impl Stage for ToneStackStage {
         // Simple lowpass for bass
         self.bass_lp = self.bass_lp + bass_alpha * (input - self.bass_lp);
 
-        // Very simplified bandpass for mids (in reality would use biquad)
+        // Proper bandpass for mids using mid_freq (still simplified but now uses the correct coefficient)
         let mid_hp = input - self.bass_lp;
-        self.mid_bp_1 = (1.0 - treble_alpha) * self.mid_bp_1 + treble_alpha * mid_hp;
+        self.mid_bp_1 = (1.0 - mid_alpha) * self.mid_bp_1 + mid_alpha * mid_hp;
         self.mid_bp_2 = mid_hp - self.mid_bp_1;
 
         // Highpass for treble