Implement various bug fixes #794
cpp-linter.yml
on: pull_request
get-vars
/
get-vars
9s
C/C++ Linter
1m 33s
Annotations
10 warnings and 10 notices
|
include/http/HTTPRequestManager.h:68:15 [modernize-use-trailing-return-type]:
include/http/HTTPRequestManager.h#L68
use a trailing return type for this function
|
|
include/http/HTTPRequestManager.h:65:160 [cppcoreguidelines-avoid-magic-numbers]:
include/http/HTTPRequestManager.h#L65
10'000 is a magic number; consider replacing it with a named constant
|
|
include/http/HTTPRequestManager.h:65:25 [modernize-use-trailing-return-type]:
include/http/HTTPRequestManager.h#L65
use a trailing return type for this function
|
|
include/http/HTTPRequestManager.h:64:242 [cppcoreguidelines-avoid-magic-numbers]:
include/http/HTTPRequestManager.h#L64
10'000 is a magic number; consider replacing it with a named constant
|
|
include/http/HTTPRequestManager.h:64:25 [modernize-use-trailing-return-type]:
include/http/HTTPRequestManager.h#L64
use a trailing return type for this function
|
|
include/http/HTTPRequestManager.h:32:24 [modernize-use-trailing-return-type]:
include/http/HTTPRequestManager.h#L32
use a trailing return type for this function
|
|
include/http/HTTPRequestManager.h:32:5 [readability-redundant-inline-specifier]:
include/http/HTTPRequestManager.h#L32
function 'ResultToString' has inline specifier but is implicitly inlined
|
|
include/http/HTTPRequestManager.h:32:5 [modernize-use-nodiscard]:
include/http/HTTPRequestManager.h#L32
function 'ResultToString' should be marked [[nodiscard]]
|
|
include/http/HTTPRequestManager.h:14:14 [performance-enum-size]:
include/http/HTTPRequestManager.h#L14
enum 'RequestResult' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size
|
|
include/http/HTTPRequestManager.h:1:1 [portability-avoid-pragma-once]:
include/http/HTTPRequestManager.h#L1
avoid 'pragma once' directive; use include guards instead
|
|
Run clang-format on src/config/Config.cpp:
src/config/Config.cpp#L0
File src/config/Config.cpp does not conform to Custom style guidelines. (lines 100, 101, 139, 140, 143, 144, 151, 152, 248, 249, 252, 253, 540, 541, 668, 669, 689, 690)
|
|
Run clang-format on src/captiveportal/RFC8908Handler.cpp:
src/captiveportal/RFC8908Handler.cpp#L0
File src/captiveportal/RFC8908Handler.cpp does not conform to Custom style guidelines. (lines 45, 46)
|
|
Run clang-format on src/WebSocketDeFragger.cpp:
src/WebSocketDeFragger.cpp#L0
File src/WebSocketDeFragger.cpp does not conform to Custom style guidelines. (lines 104, 105, 114, 115)
|
|
Run clang-format on src/VisualStateManager.cpp:
src/VisualStateManager.cpp#L0
File src/VisualStateManager.cpp does not conform to Custom style guidelines. (lines 283, 284, 312, 313, 352, 353, 416, 417, 427, 428)
|
|
Run clang-format on src/ReadWriteMutex.cpp:
src/ReadWriteMutex.cpp#L0
File src/ReadWriteMutex.cpp does not conform to Custom style guidelines. (lines 50, 51)
|
|
Run clang-format on src/GatewayConnectionManager.cpp:
src/GatewayConnectionManager.cpp#L0
File src/GatewayConnectionManager.cpp does not conform to Custom style guidelines. (lines 105, 106, 119, 120, 134, 135, 178, 179, 188, 189, 198, 199, 202, 203, 230, 231, 254, 255, 302, 303, 312, 313, 327, 328)
|
|
Run clang-format on src/GatewayClient.cpp:
src/GatewayClient.cpp#L0
File src/GatewayClient.cpp does not conform to Custom style guidelines. (lines 43, 44, 68, 69, 77, 78, 86, 87, 95, 96, 112, 113, 150, 151)
|
|
Run clang-format on src/EStopManager.cpp:
src/EStopManager.cpp#L0
File src/EStopManager.cpp does not conform to Custom style guidelines. (lines 37, 38, 39, 41, 88, 89, 93, 94, 195, 196, 253, 254)
|
|
Run clang-format on src/CommandHandler.cpp:
src/CommandHandler.cpp#L0
File src/CommandHandler.cpp does not conform to Custom style guidelines. (lines 40, 51, 52, 66, 67, 116, 117, 132, 133, 229, 230, 257, 258, 279, 280, 294, 295, 321, 322)
|
|
Run clang-format on include/http/HTTPRequestManager.h:
include/http/HTTPRequestManager.h#L0
File include/http/HTTPRequestManager.h does not conform to Custom style guidelines. (lines 71, 72, 76, 77)
|