Skip to content

Commit 5c8b915

Browse files
committed
Remove unnecessary bit-masking
1 parent 5b415a2 commit 5c8b915

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/radio/rmt/CaiXianlinEncoder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ uint64_t Rmt::CaiXianlinEncoder::MakePayload(uint16_t shockerId, uint8_t channel
4444
intensity = std::min(intensity, static_cast<uint8_t>(99));
4545

4646
// Payload layout: [shockerId:16][channel:4][type:4][intensity:8]
47-
uint32_t payload = (static_cast<uint32_t>(shockerId) << 16) | (static_cast<uint32_t>(channel & 0xF) << 12) | (static_cast<uint32_t>(typeVal & 0xF) << 8) | static_cast<uint32_t>(intensity);
47+
uint32_t payload = (static_cast<uint32_t>(shockerId) << 16) | (static_cast<uint32_t>(channel & 0xF) << 12) | (static_cast<uint32_t>(typeVal) << 8) | static_cast<uint32_t>(intensity);
4848

4949
// Calculate the checksum of the payload
5050
uint8_t checksum = Checksum::Sum8(payload);

src/radio/rmt/T330Encoder.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ uint64_t Rmt::T330Encoder::MakePayload(uint16_t shockerId, uint8_t channel, Shoc
5050
intensity = std::min(intensity, static_cast<uint8_t>(100));
5151

5252
// Payload layout: [channel:4][typeU:4][transmitterId:16][intensity:8][typeL:4][channel:4]
53-
uint64_t payload = (static_cast<uint64_t>(channelVal & 0xF) << 36) | (static_cast<uint64_t>(typeVal & 0xF0) << 28) | (static_cast<uint64_t>(shockerId) << 16) | (static_cast<uint64_t>(intensity) << 8) | (static_cast<uint64_t>(typeVal & 0xF) << 4)
54-
| static_cast<uint64_t>(channelVal & 0xF);
53+
uint64_t payload = (static_cast<uint64_t>(channelVal) << 36) | (static_cast<uint64_t>(typeVal & 0xF0) << 28) | (static_cast<uint64_t>(shockerId) << 16) | (static_cast<uint64_t>(intensity) << 8) | (static_cast<uint64_t>(typeVal & 0xF) << 4)
54+
| static_cast<uint64_t>(channelVal);
5555

5656
// Shift the data left by 1 bit to append a zero
5757
return payload << 1;

0 commit comments

Comments
 (0)