Remove erroneous "unexpected protocol: https, expected http" warning

Author: hhvrc

src/http/HTTPRequestManager.cpp

@@ -365,7 +365,11 @@ HTTP::Response<std::size_t> _doGetStream(
 )
 {
   int64_t begin = OpenShock::millis();
-  if (!client.begin(OpenShock::StringToArduinoString(url))) {
+
+  // This method is horribly named, if you call the begin() method with one String parameter its HTTP, but the one with (String, const char*) is HTTPS.
+  // We pass null here for CAcert parameter to remove erroneous "unexpected protocol: https, expected http" warning, this is what begin(String) does as a fallback.
+  // This is yet another example of why we need to get rid of Arduino dependency lol
+  if (!client.begin(OpenShock::StringToArduinoString(url), nullptr)) {
     OS_LOGE(TAG, "Failed to begin HTTP request");
     return {HTTP::RequestResult::RequestFailed, 0, 0};
   }