Optimize string assignments and enable more warnings

Author: hhvrc

include/config/Config.h

@@ -71,13 +71,13 @@ namespace OpenShock::Config {
   bool RemoveWiFiCredentials(uint8_t id);
   bool ClearWiFiCredentials();
   bool GetWiFiHostname(std::string& out);
-  bool SetWiFiHostname(std::string_view hostname);
+  bool SetWiFiHostname(std::string hostname);
 
   bool GetBackendDomain(std::string& out);
-  bool SetBackendDomain(std::string_view domain);
+  bool SetBackendDomain(std::string domain);
   bool HasBackendAuthToken();
   bool GetBackendAuthToken(std::string& out);
-  bool SetBackendAuthToken(std::string_view token);
+  bool SetBackendAuthToken(std::string token);
   bool ClearBackendAuthToken();
 
   bool GetSerialInputConfigEchoEnabled(bool& out);

platformio.ini

@@ -12,12 +12,36 @@
 platform = espressif32 @ 6.12.0
 board = az-delivery-devkit-v4 ; Overridden per board
 framework = arduino
+
+; Most warnings here are commented out because the compiler detects warnings outside own code, if we can disable external files for warnings that would be amazing!
 build_flags =
 	-std=c++2a
 	-std=gnu++2a
   -Wall
   -Wextra
-  ;-Wpedantic ; This can't be enabled yet because it screams about "ISO C++ prohibits anonymous structs in C code"
+  ;-Wpedantic
+  ;-Wcast-align
+  ;-Wcast-qual
+  ;-Wctor-dtor-privacy
+  -Wdisabled-optimization
+  -Wformat=2
+  -Winit-self
+  -Wlogical-op
+  ;-Wmissing-declarations
+  -Wmissing-include-dirs
+  ;-Wnoexcept
+  ;-Wold-style-cast
+  ;-Woverloaded-virtual
+  ;-Wredundant-decls
+  ;-Wshadow
+  ;-Wsign-conversion
+  ;-Wsign-promo
+  ;-Wstrict-null-sentinel
+  ;-Wstrict-overflow=5
+  -Wswitch-default
+  ;-Wundef
+  ;-Werror
+  -Wno-unused
   -Wno-unknown-pragmas
   -DCONFIG_ASYNC_TCP_QUEUE_SIZE=256
 build_unflags =

src/GatewayConnectionManager.cpp

@@ -126,14 +126,12 @@ AccountLinkResultCode GatewayConnectionManager::Link(std::string_view linkCode)
     return AccountLinkResultCode::InternalError;
   }
 
-  std::string_view authToken = response.data.authToken;
-
-  if (authToken.empty()) {
+  if (response.data.authToken.empty()) {
     OS_LOGE(TAG, "Received empty auth token");
     return AccountLinkResultCode::InternalError;
   }
 
-  if (!Config::SetBackendAuthToken(authToken)) {
+  if (!Config::SetBackendAuthToken(std::move(response.data.authToken))) {
     OS_LOGE(TAG, "Failed to save auth token");
     return AccountLinkResultCode::InternalError;
   }
@@ -168,7 +166,7 @@ bool GatewayConnectionManager::SendMessageBIN(tcb::span<const uint8_t> data)
   return s_wsClient->sendMessageBIN(data);
 }
 
-bool FetchHubInfo(std::string_view authToken)
+bool FetchHubInfo(std::string authToken)
 {
   // TODO: this function is very slow, should be optimized!
   if ((s_flags & FLAG_HAS_IP) == 0) {
@@ -179,7 +177,7 @@ bool FetchHubInfo(std::string_view authToken)
     return false;
   }
 
-  auto response = HTTP::JsonAPI::GetHubInfo(authToken);
+  auto response = HTTP::JsonAPI::GetHubInfo(std::move(authToken));
 
   if (response.code == 401) {
     OS_LOGD(TAG, "Auth token is invalid, waiting 5 minutes before checking again");
@@ -243,7 +241,7 @@ bool StartConnectingToLCG()
     return false;
   }
 
-  auto response = HTTP::JsonAPI::AssignLcg(authToken);
+  auto response = HTTP::JsonAPI::AssignLcg(std::move(authToken));
 
   if (response.code == 401) {
     OS_LOGD(TAG, "Auth token is invalid, waiting 5 minutes before retrying");
@@ -285,7 +283,7 @@ void GatewayConnectionManager::Update()
     }
 
     // Fetch hub info
-    if (!FetchHubInfo(authToken.c_str())) {
+    if (!FetchHubInfo(std::move(authToken))) {
       return;
     }
 

src/config/Config.cpp

@@ -575,11 +575,11 @@ bool Config::GetWiFiHostname(std::string& out)
   return true;
 }
 
-bool Config::SetWiFiHostname(std::string_view hostname)
+bool Config::SetWiFiHostname(std::string hostname)
 {
   CONFIG_LOCK_WRITE(false);
 
-  _configData.wifi.hostname = std::string(hostname);
+  _configData.wifi.hostname = std::move(hostname);
 
   return _trySaveConfig();
 }
@@ -593,11 +593,11 @@ bool Config::GetBackendDomain(std::string& out)
   return true;
 }
 
-bool Config::SetBackendDomain(std::string_view domain)
+bool Config::SetBackendDomain(std::string domain)
 {
   CONFIG_LOCK_WRITE(false);
 
-  _configData.backend.domain = std::string(domain);
+  _configData.backend.domain = std::move(domain);
   return _trySaveConfig();
 }
 
@@ -617,11 +617,11 @@ bool Config::GetBackendAuthToken(std::string& out)
   return true;
 }
 
-bool Config::SetBackendAuthToken(std::string_view token)
+bool Config::SetBackendAuthToken(std::string token)
 {
   CONFIG_LOCK_WRITE(false);
 
-  _configData.backend.authToken = std::string(token);
+  _configData.backend.authToken = std::move(token);
   return _trySaveConfig();
 }
 

src/serial/command_handlers/authtoken.cpp

@@ -26,7 +26,7 @@ void _handleAuthtokenCommand(std::string_view arg, bool isAutomated) {
 
   // If we have some other kind of request fault just set it anyway, we probably arent connected to a network
 
-  bool result = OpenShock::Config::SetBackendAuthToken(arg);
+  bool result = OpenShock::Config::SetBackendAuthToken(std::string(arg));
 
   if (result) {
     SERPR_SUCCESS("Saved config");

src/serial/command_handlers/domain.cpp

@@ -49,7 +49,7 @@ void _handleDomainCommand(std::string_view arg, bool isAutomated) {
 
   OS_LOGI(TAG, "Successfully connected to \"%.*s\", version: %s, commit: %s, current time: %s", arg.length(), arg.data(), resp.data.version.c_str(), resp.data.commit.c_str(), resp.data.currentTime.c_str());
 
-  bool result = OpenShock::Config::SetBackendDomain(arg);
+  bool result = OpenShock::Config::SetBackendDomain(std::string(arg));
 
   if (!result) {
     SERPR_ERROR("Failed to save config");

src/serial/command_handlers/hostname.cpp

@@ -20,7 +20,7 @@ void _handleHostnameCommand(std::string_view arg, bool isAutomated) {
     return;
   }
 
-  bool result = OpenShock::Config::SetWiFiHostname(arg);
+  bool result = OpenShock::Config::SetWiFiHostname(std::string(arg));
   if (result) {
     SERPR_SUCCESS("Saved config, restarting...");
     esp_restart();