Skip to content

Commit 1e00618

Browse files
authored
Merge pull request #199 from ckirmse/develop
fix grammar error with possessive its and update example code
2 parents a8d545e + 8f42a9f commit 1e00618

32 files changed

+46
-44
lines changed

CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ file(STRINGS ${CMAKE_CURRENT_SOURCE_DIR}/include/Version.h
4747
OPENSHOT_VERSION_LINES
4848
REGEX "#define[ ]+OPENSHOT_VERSION_.*[0-9]+;.*")
4949

50-
#### Set each line into it's own variable
50+
#### Set each line into its own variable
51+
5152
list (GET OPENSHOT_VERSION_LINES 0 LINE_MAJOR)
5253
list (GET OPENSHOT_VERSION_LINES 1 LINE_MINOR)
5354
list (GET OPENSHOT_VERSION_LINES 2 LINE_BUILD)

include/Clip.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ namespace openshot {
148148
void reverse_buffer(juce::AudioSampleBuffer* buffer);
149149

150150
public:
151-
GravityType gravity; ///< The gravity of a clip determines where it snaps to it's parent
152-
ScaleType scale; ///< The scale determines how a clip should be resized to fit it's parent
151+
GravityType gravity; ///< The gravity of a clip determines where it snaps to its parent
152+
ScaleType scale; ///< The scale determines how a clip should be resized to fit its parent
153153
AnchorType anchor; ///< The anchor determines what parent a clip should snap to
154154
FrameDisplayType display; ///< The format to display the frame number (if any)
155155
VolumeMixType mixing; ///< What strategy should be followed when mixing audio with other clips

include/EffectBase.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ namespace openshot
8585
/// modified openshot::Frame object
8686
///
8787
/// The frame object is passed into this method, and a frame_number is passed in which
88-
/// tells the effect which settings to use from it's keyframes (starting at 1).
88+
/// tells the effect which settings to use from its keyframes (starting at 1).
8989
///
9090
/// @returns The modified openshot::Frame object
9191
/// @param frame The frame object that needs the effect applied to it

include/FFmpegReader.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ namespace openshot {
162162
/// Check the current seek position and determine if we need to seek again
163163
bool CheckSeek(bool is_video);
164164

165-
/// Check if a frame is missing and attempt to replace it's frame image (and
165+
/// Check if a frame is missing and attempt to replace its frame image (and
166166
bool CheckMissingFrame(int64_t requested_frame);
167167

168168
/// Check the working queue, and move finished frames to the finished queue
@@ -210,10 +210,10 @@ namespace openshot {
210210
/// Read the stream until we find the requested Frame
211211
std::shared_ptr<Frame> ReadStream(int64_t requested_frame);
212212

213-
/// Remove AVFrame from cache (and deallocate it's memory)
213+
/// Remove AVFrame from cache (and deallocate its memory)
214214
void RemoveAVFrame(AVFrame *);
215215

216-
/// Remove AVPacket from cache (and deallocate it's memory)
216+
/// Remove AVPacket from cache (and deallocate its memory)
217217
void RemoveAVPacket(AVPacket *);
218218

219219
/// Seek to a specific Frame. This is not always frame accurate, it's more of an estimation on many codecs.
@@ -240,7 +240,7 @@ namespace openshot {
240240
/// frame 1, or it throws one of the following exceptions.
241241
FFmpegReader(string path);
242242

243-
/// Constructor for FFmpegReader. This only opens the media file to inspect it's properties
243+
/// Constructor for FFmpegReader. This only opens the media file to inspect its properties
244244
/// if inspect_reader=true. When not inspecting the media file, it's much faster, and useful
245245
/// when you are inflating the object using JSON after instantiating it.
246246
FFmpegReader(string path, bool inspect_reader);

include/FFmpegWriter.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ namespace openshot {
8484
* FFmpegWriter w("/home/jonathan/NewVideo.webm");
8585
*
8686
* // Set options
87-
* w.SetAudioOptions(true, "libvorbis", 44100, 2, 128000); // Sample Rate: 44100, Channels: 2, Bitrate: 128000
87+
* w.SetAudioOptions(true, "libvorbis", 44100, 2, ChannelLayout::LAYOUT_STEREO, 128000); // Sample Rate: 44100, Channels: 2, Bitrate: 128000
8888
* w.SetVideoOptions(true, "libvpx", openshot::Fraction(24,1), 720, 480, openshot::Fraction(1,1), false, false, 300000); // FPS: 24, Size: 720x480, Pixel Ratio: 1/1, Bitrate: 300000
8989
*
9090
* // Open the writer
@@ -111,7 +111,7 @@ namespace openshot {
111111
* FFmpegWriter w("/home/jonathan/NewVideo.webm");
112112
*
113113
* // Set options
114-
* w.SetAudioOptions(true, "libvorbis", 44100, 2, 128000); // Sample Rate: 44100, Channels: 2, Bitrate: 128000
114+
* w.SetAudioOptions(true, "libvorbis", 44100, 2, ChannelLayout::LAYOUT_STEREO, 128000); // Sample Rate: 44100, Channels: 2, Bitrate: 128000
115115
* w.SetVideoOptions(true, "libvpx", openshot::Fraction(24,1), 720, 480, openshot::Fraction(1,1), false, false, 300000); // FPS: 24, Size: 720x480, Pixel Ratio: 1/1, Bitrate: 300000
116116
*
117117
* // Prepare Streams (Optional method that must be called before any SetOption calls)

include/Frame.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ namespace openshot
200200
/// Clean up buffer after QImage is deleted
201201
static void cleanUpBuffer(void *info);
202202

203-
/// Clear the waveform image (and deallocate it's memory)
203+
/// Clear the waveform image (and deallocate its memory)
204204
void ClearWaveform();
205205

206206
/// Copy data and pointers from another Frame instance

include/ImageReader.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ namespace openshot
8383
/// frame 1, or it throws one of the following exceptions.
8484
ImageReader(string path);
8585

86-
/// Constructor for ImageReader. This only opens the media file to inspect it's properties
86+
/// Constructor for ImageReader. This only opens the media file to inspect its properties
8787
/// if inspect_reader=true. When not inspecting the media file, it's much faster, and useful
8888
/// when you are inflating the object using JSON after instantiating it.
8989
ImageReader(string path, bool inspect_reader);

include/ImageWriter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ namespace openshot
130130
/// @param height Height in pixels of image
131131
/// @param quality Quality of image (0 to 100, 70 is default)
132132
/// @param loops Number of times to repeat the image (used on certain multi-frame image formats, such as GIF)
133-
/// @param combine Combine frames into a single image (if possible), or save each frame as it's own image
133+
/// @param combine Combine frames into a single image (if possible), or save each frame as its own image
134134
void SetVideoOptions(string format, Fraction fps, int width, int height,
135135
int quality, int loops, bool combine);
136136

include/QtImageReader.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ namespace openshot
7979
/// frame 1, or it throws one of the following exceptions.
8080
QtImageReader(string path);
8181

82-
/// Constructor for QtImageReader. This only opens the media file to inspect it's properties
82+
/// Constructor for QtImageReader. This only opens the media file to inspect its properties
8383
/// if inspect_reader=true. When not inspecting the media file, it's much faster, and useful
8484
/// when you are inflating the object using JSON after instantiating it.
8585
QtImageReader(string path, bool inspect_reader);

include/Timeline.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ namespace openshot {
104104
* Fraction(25,1), // framerate
105105
* 44100, // sample rate
106106
* 2 // channels
107+
* ChannelLayout::LAYOUT_STEREO,
107108
* );
108109
*
109110
* // Create some clips

0 commit comments

Comments
 (0)