Skip to content

Commit 5b4bfa8

Browse files
committed
Remove mentions of nonexistent InitFileInfo()
1 parent 780d1ea commit 5b4bfa8

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

include/ReaderBase.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,7 @@ namespace openshot
5757
* @brief This struct contains info about a media file, such as height, width, frames per second, etc...
5858
*
5959
* Each derived class of ReaderBase is responsible for updating this struct to reflect accurate information
60-
* about the streams. Derived classes of ReaderBase should call the InitFileInfo() method to initialize the
61-
* default values of this struct.
60+
* about the streams.
6261
*/
6362
struct ReaderInfo
6463
{
@@ -95,7 +94,7 @@ namespace openshot
9594
*
9695
* Readers are types of classes that read video, audio, and image files, and
9796
* return openshot::Frame objects. The only requirements for a 'reader', are to
98-
* derive from this base class, implement the GetFrame method, and call the InitFileInfo() method.
97+
* derive from this base class, implement the GetFrame method, and populate ReaderInfo.
9998
*/
10099
class ReaderBase
101100
{

src/EffectBase.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
using namespace openshot;
3434

35-
// Initialize the values of the FileInfo struct
35+
// Initialize the values of the EffectInfo struct
3636
void EffectBase::InitEffectInfo()
3737
{
3838
// Init clip settings

tests/ReaderBase_Tests.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ TEST(ReaderBase_Derived_Class)
5959
TestReader t1;
6060

6161
// Check some of the default values of the FileInfo struct on the base class
62-
// If InitFileInfo() is not called in the derived class, these checks would fail.
6362
CHECK_EQUAL(false, t1.info.has_audio);
6463
CHECK_EQUAL(false, t1.info.has_audio);
6564
CHECK_CLOSE(0.0f, t1.info.duration, 0.00001);

0 commit comments

Comments
 (0)