Skip to content

Commit 7b94ac8

Browse files
committed
Removing bad suggestion. In theory, we could change this signature to take a const reference to a string, but for now, I'm reverting it.
1 parent 51fe854 commit 7b94ac8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

include/FFmpegWriter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ namespace openshot {
253253

254254
/// @brief Constructor for FFmpegWriter. Throws one of the following exceptions.
255255
/// @param path The file path of the video file you want to open and read
256-
FFmpegWriter(const std::string path);
256+
FFmpegWriter(std::string path);
257257

258258
/// Close the writer
259259
void Close();

src/FFmpegWriter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ static int set_hwframe_ctx(AVCodecContext *ctx, AVBufferRef *hw_device_ctx, int6
8383
}
8484
#endif // HAVE_HW_ACCEL
8585

86-
FFmpegWriter::FFmpegWriter(const std::string path) :
86+
FFmpegWriter::FFmpegWriter(std::string path) :
8787
path(path), fmt(NULL), oc(NULL), audio_st(NULL), video_st(NULL), samples(NULL),
8888
audio_outbuf(NULL), audio_outbuf_size(0), audio_input_frame_size(0), audio_input_position(0),
8989
initial_audio_input_frame_size(0), img_convert_ctx(NULL), cache_size(8), num_of_rescalers(32),

0 commit comments

Comments
 (0)