Skip to content

Commit 45f4bdd

Browse files
Merge pull request #1282 from OpenSignLabs/form-layout
fix: document download issue in the disabled OTP public sign flow before signing and subscription issue in the guest login process
2 parents 20c21cb + c8f5c80 commit 45f4bdd

File tree

9 files changed

+32
-38
lines changed

9 files changed

+32
-38
lines changed

apps/OpenSign/public/locales/en/translation.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -265,10 +265,10 @@
265265
"make-template-public-alert": "Are you sure you want to make this template public?",
266266
"make-template-private-alert": "Are you sure you want to make this template private? This will remove it from your public profile.",
267267
"public-role": "Public role",
268-
"public-url": "Public URL",
268+
"public-url": "Public profile needed",
269269
"public-url-copy": "Here’s your public URL: ",
270270
"public-url-copy-mssg":"Copy it or share it with the signer, and you will be able to see all your publicly set templates.",
271-
"add-public-url-alert": "Please add your public URL, and you will be able to make a public template.",
271+
"add-public-url-alert": "Please complete your OpenSign public profile setup. Once done, you’ll be able to make templates public. This process only needs to be completed once.",
272272
"share-with-alert": "You cannot share a template if any roles already have contacts assigned. Please remove all contact assignments from the roles before sharing the template.",
273273
"share-with": "Share with",
274274
"team-not-found": "Team not found",
@@ -672,6 +672,7 @@
672672
"document-logs":"Document logs",
673673
"server-down": "Unable to connect to the OpenSign server. If you are self-hosting OpenSign, please ensure that all the steps in the documentation have been followed correctly. If you're running OpenSign locally, you might be accessing it through an incorrect port number.",
674674
"admin-exists": "Admin already exists. Please login to the application using admin credentials in order to manage users.",
675-
"public-tour-message":"Please make template public to copy public URL"
675+
"public-tour-message":"The template needs to be public before you can generate a shareable link.",
676+
"add-user-template": "You need to add a role before you can add fields for it."
676677

677678
}

apps/OpenSign/public/locales/fr/translation.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,10 +264,10 @@
264264
"make-template-public-alert": "Êtes-vous sûr de vouloir rendre ce modèle public ?",
265265
"make-template-private-alert": "Êtes-vous sûr de vouloir rendre ce modèle privé ? Cela le supprimera de votre profil public.",
266266
"public-role": "Rôle public",
267-
"public-url": "URL publique",
267+
"public-url": "Profil public requis",
268268
"public-url-copy": "Voici votre URL publique : ",
269269
"public-url-copy-mssg": "copiez-la ou partagez-le avec le signataire et vous pouvoir voir tous vos paramètres publics modèles.",
270-
"add-public-url-alert": "Veuillez ajouter votre URL publique et vous pourra rendre public modèle.",
270+
"add-public-url-alert": "Veuillez terminer la configuration de votre profil public OpenSign. Une fois cela fait, vous pourrez rendre les modèles publics. Ce processus ne doit être effectué qu’une seule fois.",
271271
"share-with-alert": "Vous ne pouvez pas partager un modèle si des contacts sont déjà attribués à des rôles. Veuillez supprimer toutes les attributions de contacts des rôles avant de partager le modèle.",
272272
"share-with": "Partager avec",
273273
"team-not-found": "Équipe introuvable",
@@ -671,7 +671,8 @@
671671
"document-logs":"Journaux de documents",
672672
"server-down": "Impossible de se connecter au serveur OpenSign. Si vous hébergez vous-même OpenSign, veuillez vous assurer que toutes les étapes de la documentation ont été correctement suivies. Si vous exécutez OpenSign localement, vous y accédez peut-être via un numéro de port incorrect.",
673673
"admin-exists": "L'administrateur existe déjà. Veuillez vous connecter à l'application en utilisant les informations d'identification de l'administrateur afin de gérer les utilisateurs.",
674-
"public-tour-message":"Veuillez rendre le modèle public pour copier l'URL publique"
674+
"public-tour-message": "Le modèle doit être public avant que vous puissiez générer un lien partageable.",
675+
"add-user-template":"Vous devez ajouter un rôle avant de pouvoir lui ajouter des champs. "
675676

676677

677678
}

apps/OpenSign/src/components/pdf/PdfHeader.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -418,11 +418,7 @@ function Header({
418418
{templateId && (
419419
<button
420420
onClick={() =>
421-
handleDownloadPdf(
422-
pdfDetails,
423-
pdfUrl,
424-
setIsDownloading
425-
)
421+
handleDownloadPdf(pdfDetails, setIsDownloading)
426422
}
427423
type="button"
428424
className="op-btn op-btn-ghost op-btn-sm mr-[3px]"

apps/OpenSign/src/pages/PdfRequestFiles.js

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ function PdfRequestFiles(props) {
7373
const [selectWidgetId, setSelectWidgetId] = useState("");
7474
const [otpLoader, setOtpLoader] = useState(false);
7575
const [isCelebration, setIsCelebration] = useState(false);
76-
const [requestSignTour, setRequestSignTour] = useState(false);
76+
const [requestSignTour, setRequestSignTour] = useState(true);
7777
const [tourStatus, setTourStatus] = useState([]);
7878
const [isLoading, setIsLoading] = useState({
7979
isLoad: true,
@@ -129,7 +129,7 @@ function PdfRequestFiles(props) {
129129
const [contact, setContact] = useState({ name: "", phone: "", email: "" });
130130
const [isOtp, setIsOtp] = useState(false);
131131
const [loading, setLoading] = useState(false);
132-
const [res, setRes] = useState({});
132+
const [publicRes, setPublicRes] = useState({});
133133
const [documentId, setDocumentId] = useState("");
134134
const [isPublicContact, setIsPublicContact] = useState(false);
135135
const [pdfArrayBuffer, setPdfArrayBuffer] = useState("");
@@ -429,7 +429,7 @@ function PdfRequestFiles(props) {
429429

430430
currUserId = getCurrentSigner?.objectId
431431
? getCurrentSigner.objectId
432-
: signerObjectId || "";
432+
: contactBookId || signerObjectId || "";
433433
if (isEnableSubscription) {
434434
await checkIsSubscribed(
435435
documentData[0]?.ExtUserPtr?.objectId,
@@ -1510,16 +1510,14 @@ function PdfRequestFiles(props) {
15101510
);
15111511

15121512
if (userRes?.data?.result) {
1513-
setRes(userRes.data.result);
1513+
setPublicRes(userRes.data.result);
15141514
const isEnableOTP = pdfDetails?.[0]?.IsEnableOTP || false;
15151515
if (isEnableOTP) {
15161516
await SendOtp();
15171517
} else {
15181518
setIsPublicContact(false);
15191519
setIsPublicTemplate(false);
1520-
setLoading(false);
15211520
setDocumentId(userRes.data?.result?.docId);
1522-
getDocumentDetails(userRes?.data?.result?.docId);
15231521
const contactId = userRes.data.result?.contactId;
15241522
setSignerObjectId(contactId);
15251523
}
@@ -1564,7 +1562,7 @@ function PdfRequestFiles(props) {
15641562

15651563
const SendOtp = async () => {
15661564
try {
1567-
const params = { email: contact.email, docId: res.docId };
1565+
const params = { email: contact.email, docId: publicRes?.docId };
15681566
const Otp = await axios.post(
15691567
`${localStorage.getItem("baseUrl")}/functions/SendOTPMailV1`,
15701568
params,
@@ -1630,17 +1628,13 @@ function PdfRequestFiles(props) {
16301628
JSON.stringify(contractUserDetails)
16311629
);
16321630
}
1633-
16341631
localStorage.setItem("username", _user.name);
16351632
localStorage.setItem("accesstoken", _user.sessionToken);
16361633
setLoading(false);
1637-
// navigate(`/load/recipientSignPdf/${res?.docId}/${res?.contactId}`);
1638-
// document.getElementById("my_modal").close();
16391634
setIsPublicContact(false);
16401635
setIsPublicTemplate(false);
16411636
setIsLoading({ isLoad: false });
1642-
setDocumentId(res?.docId);
1643-
getDocumentDetails(res?.docId);
1637+
setDocumentId(publicRes?.docId);
16441638
}
16451639
} catch (error) {
16461640
console.log("err ", error);

apps/OpenSign/src/pages/TemplatePlaceholder.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@ const TemplatePlaceholder = () => {
508508
const tourAddRole = [
509509
{
510510
selector: '[data-tut="reactourAddbtn"]',
511-
content: "You need to add a role before you can add fields for it. ",
511+
content: t("add-user-template"),
512512
position: "top",
513513
style: { fontSize: "13px" }
514514
}

apps/OpenSign/src/pages/UserProfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ function UserProfile() {
611611
<div className="flex flex-row md:items-center gap-1">
612612
{editmode || !extendUser?.[0]?.Tagline ? (
613613
<input
614-
maxLength={40}
614+
maxLength={100}
615615
onChange={handleOnchangeTagLine}
616616
value={tagLine}
617617
disabled={!editmode}

apps/OpenSign/src/primitives/GetReportDisplay.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1511,14 +1511,14 @@ const ReportTable = (props) => {
15111511
<span>{t("public-url-copy")}</span>
15121512
<div className=" flex items-center justify-between gap-3 p-[2px] ">
15131513
<div className="w-[280px] whitespace-nowrap overflow-hidden text-ellipsis">
1514-
<span
1515-
onClick={() =>
1516-
copytoProfileLink()
1517-
}
1514+
<a
1515+
rel="noreferrer"
1516+
target="_blank"
1517+
href={publicUrl()}
15181518
className="ml-[2px] underline underline-offset-2 cursor-pointer text-blue-800"
15191519
>
15201520
{publicUrl()}
1521-
</span>
1521+
</a>
15221522
</div>
15231523
<div className="flex items-center gap-2">
15241524
<RWebShare
@@ -1535,7 +1535,7 @@ const ReportTable = (props) => {
15351535
</button>
15361536
</RWebShare>
15371537
<button
1538-
className="op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm"
1538+
className="op-btn op-btn-primary op-btn-outline op-btn-xs md:op-btn-sm md:w-[100px]"
15391539
onClick={() =>
15401540
copytoProfileLink()
15411541
}
@@ -1561,7 +1561,7 @@ const ReportTable = (props) => {
15611561
className="mt-3 op-btn op-btn-primary"
15621562
onClick={() => navigate("/profile")}
15631563
>
1564-
{t("add")}
1564+
{t("Proceed")}
15651565
</button>
15661566
</div>
15671567
)}

apps/OpenSign/src/script/locales/en/translation.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -265,10 +265,10 @@
265265
"make-template-public-alert": "Are you sure you want to make this template public?",
266266
"make-template-private-alert": "Are you sure you want to make this template private? This will remove it from your public profile.",
267267
"public-role": "Public role",
268-
"public-url": "Public URL",
268+
"public-url": "Public profile needed",
269269
"public-url-copy": "Here’s your public URL: ",
270270
"public-url-copy-mssg": "Copy it or share it with the signer, and you will be able to see all your publicly set templates.",
271-
"add-public-url-alert": "Please add your public URL, and you will be able to make a public template.",
271+
"add-public-url-alert": "Please complete your OpenSign public profile setup. Once done, you’ll be able to make templates public. This process only needs to be completed once.",
272272
"share-with-alert": "You cannot share a template if any roles already have contacts assigned. Please remove all contact assignments from the roles before sharing the template.",
273273
"share-with": "Share with",
274274
"team-not-found": "Team not found",
@@ -672,5 +672,6 @@
672672
"document-logs": "Document logs",
673673
"server-down": "Unable to connect to the OpenSign server. If you are self-hosting OpenSign, please ensure that all the steps in the documentation have been followed correctly. If you're running OpenSign locally, you might be accessing it through an incorrect port number.",
674674
"admin-exists": "Admin already exists. Please login to the application using admin credentials in order to manage users.",
675-
"public-tour-message": "Please make template public to copy public URL"
675+
"public-tour-message":"The template needs to be public before you can generate a shareable link.",
676+
"add-user-template": "You need to add a role before you can add fields for it."
676677
}

apps/OpenSign/src/script/locales/fr/translation.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,10 +264,10 @@
264264
"make-template-public-alert": "Êtes-vous sûr de vouloir rendre ce modèle public ?",
265265
"make-template-private-alert": "Êtes-vous sûr de vouloir rendre ce modèle privé ? Cela le supprimera de votre profil public.",
266266
"public-role": "Rôle public",
267-
"public-url": "URL publique",
267+
"public-url": "Profil public requis",
268268
"public-url-copy": "Voici votre URL publique : ",
269269
"public-url-copy-mssg": "copiez-la ou partagez-le avec le signataire et vous pouvoir voir tous vos paramètres publics modèles.",
270-
"add-public-url-alert": "Veuillez ajouter votre URL publique et vous pourra rendre public modèle.",
270+
"add-public-url-alert": "Veuillez terminer la configuration de votre profil public OpenSign. Une fois cela fait, vous pourrez rendre les modèles publics. Ce processus ne doit être effectué qu’une seule fois.",
271271
"share-with-alert": "Vous ne pouvez pas partager un modèle si des contacts sont déjà attribués à des rôles. Veuillez supprimer toutes les attributions de contacts des rôles avant de partager le modèle.",
272272
"share-with": "Partager avec",
273273
"team-not-found": "Équipe introuvable",
@@ -671,5 +671,6 @@
671671
"document-logs": "Journaux de documents",
672672
"server-down": "Impossible de se connecter au serveur OpenSign. Si vous hébergez vous-même OpenSign, veuillez vous assurer que toutes les étapes de la documentation ont été correctement suivies. Si vous exécutez OpenSign localement, vous y accédez peut-être via un numéro de port incorrect.",
673673
"admin-exists": "L'administrateur existe déjà. Veuillez vous connecter à l'application en utilisant les informations d'identification de l'administrateur afin de gérer les utilisateurs.",
674-
"public-tour-message": "Veuillez rendre le modèle public pour copier l'URL publique"
674+
"public-tour-message": "Le modèle doit être public avant que vous puissiez générer un lien partageable.",
675+
"add-user-template":"Vous devez ajouter un rôle avant de pouvoir lui ajouter des champs. "
675676
}

0 commit comments

Comments
 (0)