Skip to content

Commit 9c1b426

Browse files
Merge pull request #1316 from OpenSignLabs/validation
refactor: changes in output of file-adapter's cloud function
2 parents dc7fd34 + 7c37d81 commit 9c1b426

File tree

2 files changed

+9
-26
lines changed

2 files changed

+9
-26
lines changed

apps/OpenSignServer/cloud/parsefunction/addFileAdapter.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export default async function addFileAdapter(request) {
3939
// assign existing file adapters or empty array
4040
let updatedFileAdapters = existsFileAdaptes;
4141
const uniqueId = generateId(10);
42-
const id = extUser?.get('TenantId')?.id + '_' + uniqueId;
42+
let id = extUser?.get('TenantId')?.id + '_' + uniqueId;
4343
const index = updatedFileAdapters?.findIndex(x => x.fileAdapterName === fileAdapterName);
4444

4545
if (index !== -1) {
@@ -52,6 +52,7 @@ export default async function addFileAdapter(request) {
5252
} else {
5353
const adapterConfig = { accessKeyId: accessKeyId, secretAccessKey: secretAccessKey };
5454
updatedFileAdapters[index] = { ...updatedFileAdapters[index], ...adapterConfig };
55+
id = updatedFileAdapters[index].id;
5556
}
5657
} else {
5758
if (bucketName && region && endpoint && baseUrl) {
@@ -90,7 +91,8 @@ export default async function addFileAdapter(request) {
9091
protectedFields: { '*': ['FileAdapters'] },
9192
});
9293
await tenantSchema.update();
93-
return updateTenant.updatedAt;
94+
const ActiveFileAdapter = adapter === 'opensign' ? 'opensign' : id;
95+
return { ActiveFileAdapter: ActiveFileAdapter, updateAt: updateTenant.updatedAt };
9496
} else {
9597
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'User not found.');
9698
}
@@ -123,7 +125,7 @@ export default async function addFileAdapter(request) {
123125
protectedFields: { '*': ['FileAdapters'] },
124126
});
125127
await tenantSchema.update();
126-
return updateTenant.updatedAt;
128+
return { ActiveFileAdapter: 'opensign', updateAt: updateTenant.updatedAt };
127129
} else {
128130
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'User not found.');
129131
}

apps/OpenSignServer/cloud/parsefunction/getFileAdapter.js

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,10 @@ export default async function getFileAdapter(request) {
99
const extUser = await extUserCls.first({ useMasterKey: true });
1010
if (extUser) {
1111
const _extUser = JSON.parse(JSON.stringify(extUser));
12-
const isFileAdapter = _extUser?.TenantId?.FileAdapters?.length > 0 ? true : false;
13-
if (_extUser?.TenantId?.ActiveFileAdapter && isFileAdapter) {
14-
const lastIndex = _extUser?.TenantId?.FileAdapters?.length - 1;
15-
const lastObj = _extUser?.TenantId?.FileAdapters[lastIndex];
16-
if (lastIndex >= 0) {
17-
const adapterConfig = {
18-
id: lastObj?.id,
19-
fileAdapterName: lastObj?.fileAdapterName,
20-
bucketName: lastObj?.bucketName,
21-
region: lastObj?.region,
22-
endpoint: lastObj?.endpoint,
23-
baseUrl: lastObj?.baseUrl,
24-
accessKeyId: lastObj?.accessKeyId,
25-
secretAccessKey: lastObj?.secretAccessKey,
26-
fileAdapter: lastObj?.fileAdapter,
27-
};
28-
return adapterConfig;
29-
} else {
30-
return {};
31-
}
32-
} else {
33-
return {};
34-
}
12+
const FileAdapters =
13+
_extUser?.TenantId?.FileAdapters?.length > 0 ? _extUser?.TenantId?.FileAdapters : [];
14+
const ActiveFileAdapter = _extUser?.TenantId?.ActiveFileAdapter || 'opensign';
15+
return { ActiveFileAdapter: ActiveFileAdapter, FileAdapters: FileAdapters };
3516
} else {
3617
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'User not found.');
3718
}

0 commit comments

Comments
 (0)