Fix a possible illegal construct for the surgetank icon.

See also discussion in OpenModelica/OpenModelica#13092

Author: dietmarw

OpenHPL/Icons/Surge.mo

@@ -1,5 +1,7 @@
 within OpenHPL.Icons;
 partial class Surge "Surge tank/shaft icon"
+  input SI.Length lds "Lenght of watercolumn in the surge shaft(for DynamicSelect)";
+  input SI.Length Lds "Length of the surge shaft (for DynamicSelect)";
   annotation (
     Icon(coordinateSystem(preserveAspectRatio=false, grid={1,1}),
                                                         graphics={
@@ -32,7 +34,7 @@ partial class Surge "Surge tank/shaft icon"
           pattern=LinePattern.None),
         Rectangle(
           extent=DynamicSelect({{-30,60},{30,18}},
-                {{-30,(20+70*l/L)},{30,18}}),
+                {{-30,(20+70*lds/Lds)},{30,18}}),
           lineColor={28,108,200},
           fillColor={0,128,255},
           fillPattern=FillPattern.Solid,

OpenHPL/Waterway/SurgeTank.mo

@@ -1,7 +1,8 @@
 within OpenHPL.Waterway;
 model SurgeTank "Model of the surge tank/shaft"
   outer Data data "Using standard data set";
-  extends OpenHPL.Icons.Surge;
+  extends OpenHPL.Icons.Surge(lds=l, Lds=L);
+  extends OpenHPL.Interfaces.ContactNode;
   import Modelica.Constants.pi;
 
   parameter Types.SurgeTank SurgeTankType = OpenHPL.Types.SurgeTank.STSimple "Types of surge tank" annotation (
@@ -59,7 +60,7 @@ model SurgeTank "Model of the surge tank/shaft"
   // variables for temperature. Not in use for now...
   // Real W_f, W_e;
   // connector (acquisition of algebraic variable, mass flow rate mdot, and node pressure (manifold pressure) p_n)
-  extends OpenHPL.Interfaces.ContactNode;
+
 initial equation
   if SteadyState then
     der(M) = 0;