Start of actions cleanup

Author: vkrasnovyd

docs/actions/motion.create.md

@@ -62,7 +62,6 @@ There are some fields that need special attention:
 - `agenda_*`: See [Agenda](https://github.com/OpenSlides/OpenSlides/wiki/Agenda#additional-fields-during-creation-of-agenda-content-objects).
 
 Other things to do when creating motions:
-- Set the field `sequential_number`: It is the `max+1` of `sequential_number` of all motions in the same meeting. If there are no other motions in this meeting (e.g. this is the first one), it gets 1.
 - Set timestamps:
   - always set `last_modified` and `created` to the current timestamp
   - if the state pointed to by `first_state_id` of the given workflow has the flag `set_workflow_timestamp` set, also set `workflow_timestamp`to the current timestamp.
@@ -98,7 +97,7 @@ This is the procedure to determine what to set for the field `number`:
   * Remember: `number` must be unique. If a motion with this number already exists, increment `number_value` by one and go to the last step (the prefix is the same, the number incremented - try again).
   * If there is a unique `number`, save it into the motion. Done!
   * Note: The complete calculation is restricted to motions and other objects from the same meeting.
- 
+
 ### Some examples for determinating the number. First comes the general setup and the test cases are numbered:
 
 `meeting/motions_number_type="manually"`

docs/actions/motion.create_forwarded.md

@@ -56,7 +56,6 @@ The result object for each instance has the format
 ```
 {
   id: Id,
-  sequential_number: int,
   non_forwarded_amendment_amount: int, // Number of amendments that couldn't be returned because of forwarding being not allowed in the state
   amendment_result_data: [...], // List of result data objects in the same format, for all newly created amendments for the newly created motion
 }

openslides_backend/action/actions/list_of_speakers/create.py

@@ -5,12 +5,11 @@
 from ...mixins.create_action_with_inferred_meeting import (
     CreateActionWithInferredMeeting,
 )
-from ...mixins.sequential_numbers_mixin import SequentialNumbersMixin
 from ...util.default_schema import DefaultSchema
 
 
 # This action is not registered because you can not call it from outside.
-class ListOfSpeakersCreate(SequentialNumbersMixin, CreateActionWithInferredMeeting):
+class ListOfSpeakersCreate(CreateActionWithInferredMeeting):
     name = "list_of_speakers.create"
     model = ListOfSpeakers()
     schema = DefaultSchema(ListOfSpeakers()).get_create_schema(["content_object_id"])

openslides_backend/action/actions/motion/base_create_forwarded.py

@@ -197,8 +197,6 @@ def update_instance(self, instance: dict[str, Any]) -> dict[str, Any]:
         else:
             name = committee.get("name", f"Committee {committee['id']}")
             instance["additional_submitter"] = name
-
-        self.set_sequential_number(instance)
         self.handle_number(instance)
         self.set_origin_ids(instance)
         self.set_text_hash(instance)

openslides_backend/action/actions/motion/create.py

@@ -131,7 +131,6 @@ def update_instance(self, instance: dict[str, Any]) -> dict[str, Any]:
 
         self.set_state_from_workflow(instance, meeting)
         self.create_submitters(instance)
-        self.set_sequential_number(instance)
         self.set_created_last_modified_and_number(instance)
         self.set_text_hash(instance)
         instance = super().update_instance(instance)

openslides_backend/action/actions/motion/create_base.py

@@ -5,7 +5,6 @@
 from ....models.models import Motion
 from ....shared.patterns import fqid_from_collection_and_id
 from ...mixins.create_action_with_dependencies import CreateActionWithDependencies
-from ...mixins.sequential_numbers_mixin import SequentialNumbersMixin
 from ..agenda_item.agenda_creation import CreateActionWithAgendaItemMixin
 from ..agenda_item.create import AgendaItemCreate
 from ..list_of_speakers.create import ListOfSpeakersCreate
@@ -22,7 +21,6 @@ class MotionCreateBase(
     MeetingUserHelperMixin,
     CreateActionWithDependencies,
     CreateActionWithAgendaItemMixin,
-    SequentialNumbersMixin,
     SetNumberMixin,
     CreateActionWithListOfSpeakersMixin,
 ):
@@ -64,11 +62,6 @@ def create_submitters(self, instance: dict[str, Any]) -> None:
                 MotionSubmitterCreateAction, [data], skip_history=True
             )
 
-    def set_sequential_number(self, instance: dict[str, Any]) -> None:
-        instance["sequential_number"] = self.get_sequential_number(
-            instance["meeting_id"]
-        )
-
     def set_created_last_modified_and_number(self, instance: dict[str, Any]) -> None:
         self.set_created_last_modified(instance)
         self.set_number(

openslides_backend/action/actions/poll/create.py

@@ -8,7 +8,6 @@
 from ....shared.schema import decimal_schema, id_list_schema, optional_fqid_schema
 from ...generics.create import CreateAction
 from ...mixins.forbid_anonymous_group_mixin import ForbidAnonymousGroupMixin
-from ...mixins.sequential_numbers_mixin import SequentialNumbersMixin
 from ...util.default_schema import DefaultSchema
 from ...util.register import register_action
 from ..option.create import OptionCreateAction
@@ -33,7 +32,6 @@
 @register_action("poll.create")
 class PollCreateAction(
     PollValidationMixin,
-    SequentialNumbersMixin,
     CreateAction,
     PollPermissionMixin,
     PollHistoryMixin,

openslides_backend/action/actions/projector/create.py

@@ -1,13 +1,12 @@
 from ....models.models import Meeting, Projector
 from ....permissions.permissions import Permissions
 from ...generics.create import CreateAction
-from ...mixins.sequential_numbers_mixin import SequentialNumbersMixin
 from ...util.default_schema import DefaultSchema
 from ...util.register import register_action
 
 
 @register_action("projector.create")
-class ProjectorCreateAction(SequentialNumbersMixin, CreateAction):
+class ProjectorCreateAction(CreateAction):
     """
     Action to create a projector.
     """

openslides_backend/action/actions/topic/create.py

@@ -5,7 +5,6 @@
 from ....shared.schema import id_list_schema
 from ...action import Action
 from ...mixins.create_action_with_dependencies import CreateActionWithDependencies
-from ...mixins.sequential_numbers_mixin import SequentialNumbersMixin
 from ...util.default_schema import DefaultSchema
 from ...util.register import register_action
 from ..agenda_item.agenda_creation import (
@@ -23,7 +22,6 @@
 @register_action("topic.create")
 class TopicCreate(
     AttachmentMixin,
-    SequentialNumbersMixin,
     CreateActionWithDependencies,
     CreateActionWithAgendaItemMixin,
     CreateActionWithListOfSpeakersMixin,

openslides_backend/models/fields.py

@@ -121,6 +121,8 @@ def get_schema(self) -> Schema:
     def check_required_not_fulfilled(
         self, instance: dict[str, Any], is_create: bool
     ) -> bool:
+        if self.constraints.get("sequence_scope"):
+            return False
         if self.own_field_name not in instance:
             return is_create
         return instance[self.own_field_name] is None