Meeting_export with 4.2.29 compatibility (#3388)

Author: vkrasnovyd

openslides_backend/presenter/export_meeting.py

@@ -18,6 +18,7 @@
         "description": "export meeting",
         "properties": {
             "meeting_id": required_id_schema,
+            "old_db_compatibility": {"type": "boolean"},
         },
     }
 )
@@ -41,7 +42,10 @@ def get_result(self) -> Any:
             msg += f" Missing permission: {OrganizationManagementLevel.SUPERADMIN}"
             raise PermissionDenied(msg)
         export_data = export_meeting(
-            self.datastore, self.data["meeting_id"], datetime_decimal_to_string=True
+            self.datastore,
+            self.data["meeting_id"],
+            transform_datetime_decimal=True,
+            datetime_to_unix=self.data.get("old_db_compatibility"),
         )
         if id_ := next(
             (
@@ -53,6 +57,8 @@ def get_result(self) -> Any:
         ):
             raise PresenterException(f"Cannot export: meeting {id_} is locked.")
         self.exclude_organization_tags_and_default_meeting_for_committee(export_data)
+        if self.data.get("old_db_compatibility"):
+            self.add_missing_mm_inherited_access_group_ids(export_data)
         return export_data
 
     def exclude_organization_tags_and_default_meeting_for_committee(
@@ -63,6 +69,15 @@ def exclude_organization_tags_and_default_meeting_for_committee(
             "default_meeting_for_committee_id", None
         )
 
+    def add_missing_mm_inherited_access_group_ids(
+        self, export_data: dict[str, Any]
+    ) -> None:
+        if "meeting_mediafile" not in export_data:
+            return
+        for meeting_mediafile_data in export_data["meeting_mediafile"].values():
+            if "inherited_access_group_ids" not in meeting_mediafile_data:
+                meeting_mediafile_data["inherited_access_group_ids"] = []
+
     def get_meeting_from_json(self, export_data: Any) -> Any:
         key = next(iter(export_data["meeting"]))
         return export_data["meeting"][key]

openslides_backend/shared/export_helper.py

@@ -36,7 +36,8 @@ def export_meeting(
     meeting_id: int,
     internal_target: bool = False,
     update_mediafiles: bool = False,
-    datetime_decimal_to_string: bool = False,
+    transform_datetime_decimal: bool = False,
+    datetime_to_unix: bool = False,
 ) -> dict[str, Any]:
     export: dict[str, Any] = {}
 
@@ -215,11 +216,15 @@ def export_meeting(
         export[collection] = dict(
             sorted(instances.items(), key=lambda item: int(item[0]))
         )
-        if datetime_decimal_to_string and isinstance(instances, dict):
+        if transform_datetime_decimal and isinstance(instances, dict):
             for data in instances.values():
                 for field, value in data.items():
                     if isinstance(value, datetime.datetime):
-                        data[field] = value.isoformat()
+                        if datetime_to_unix:
+                            clean_value = value.replace(microsecond=0)
+                            data[field] = clean_value.timestamp()
+                        else:
+                            data[field] = value.isoformat()
                     if isinstance(value, Decimal):
                         data[field] = str(value)
 

tests/system/presenter/test_export_meeting.py

@@ -474,3 +474,82 @@ def test_with_structured_published_orga_files(self) -> None:
         assert status_code == 200
         # Should not include mediafile ids bc presenter does not include orga mediafiles
         assert data["mediafile"] == {}
+
+    def base_test_export_with_timestamps_old_db_compatibility(
+        self, old_db_compatibility: bool
+    ) -> None:
+        meeting_timestamp_unix = 626637600
+        meeting_timestamp_string = "1989-11-09T18:00:00+00:00"
+        motion_timestamp_unix = 1033479479
+        motion_timestamp_string = "2002-10-01T13:37:59.687459+00:00"
+        self.set_models(
+            {
+                "meeting/1": {
+                    "start_time": datetime.fromtimestamp(
+                        meeting_timestamp_unix, tz=ZoneInfo("Europe/Berlin")
+                    )
+                }
+            }
+        )
+        self.create_motion(
+            1,
+            1,
+            motion_data={
+                "created": datetime.fromtimestamp(
+                    1033479479.687459, tz=ZoneInfo("Europe/Berlin")
+                )
+            },
+        )
+        old_db_compatibility_data = (
+            {"old_db_compatibility": True} if old_db_compatibility else {}
+        )
+        status_code, data = self.request(
+            "export_meeting",
+            {"meeting_id": 1, **old_db_compatibility_data},
+        )
+        assert status_code == 200
+        if old_db_compatibility:
+            assert data["meeting"]["1"]["start_time"] == meeting_timestamp_unix
+            assert data["motion"]["1"]["created"] == motion_timestamp_unix
+        else:
+            assert data["meeting"]["1"]["start_time"] == meeting_timestamp_string
+            assert data["motion"]["1"]["created"] == motion_timestamp_string
+
+    def test_export_with_timestamps_old_db_compatibility_true(self) -> None:
+        self.base_test_export_with_timestamps_old_db_compatibility(True)
+
+    def test_export_with_timestamps_old_db_compatibility_false(self) -> None:
+        self.base_test_export_with_timestamps_old_db_compatibility(False)
+
+    def base_test_export_without_mmiagi_old_db_compatibility(
+        self, old_db_compatibility: bool
+    ) -> None:
+        self.create_mediafile(1, 1)
+        self.set_models(
+            {
+                "meeting_mediafile/1": {
+                    "is_public": False,
+                    "meeting_id": 1,
+                    "mediafile_id": 1,
+                },
+            }
+        )
+        old_db_compatibility_data = (
+            {"old_db_compatibility": True} if old_db_compatibility else {}
+        )
+        status_code, data = self.request(
+            "export_meeting",
+            {"meeting_id": 1, **old_db_compatibility_data},
+        )
+        assert status_code == 200
+        if old_db_compatibility:
+            assert data["meeting_mediafile"]["1"]["inherited_access_group_ids"] == []
+        else:
+            assert "inherited_access_group_ids" not in data["meeting_mediafile"]["1"]
+        assert "access_group_ids" not in data["meeting_mediafile"]["1"]
+
+    def test_export_without_mmiagi_old_db_compatibility_true(self) -> None:
+        self.base_test_export_without_mmiagi_old_db_compatibility(True)
+
+    def test_export_without_mmiagi_old_db_compatibility_false(self) -> None:
+        self.base_test_export_without_mmiagi_old_db_compatibility(False)