Skip to content

Remove cascading deletion between meeting user and motion relations - #3164

Merged
luisa-beerboom merged 6 commits into
OpenSlides:mainfrom
luisa-beerboom:3105-remove-cascading-between-meeting-user-and-motion-relation-models
Nov 4, 2025
Merged

Remove cascading deletion between meeting user and motion relations#3164
luisa-beerboom merged 6 commits into
OpenSlides:mainfrom
luisa-beerboom:3105-remove-cascading-between-meeting-user-and-motion-relation-models

Conversation

@luisa-beerboom

Copy link
Copy Markdown
Member

@luisa-beerboom luisa-beerboom added this to the 4.3 milestone Oct 1, 2025
@luisa-beerboom luisa-beerboom added enhancement General enhancement which is neither bug nor feature Schrödinger projectname labels Oct 1, 2025

@vkrasnovyd vkrasnovyd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there a reason why you didn't add motion_working_group_speaker and motion_editor to the user.delete tests?

@luisa-beerboom

Copy link
Copy Markdown
Member Author

Looks good. Is there a reason why you didn't add motion_working_group_speaker and motion_editor to the user.delete tests?

Because they're already tested via the meeting_user test

@Elblinator Elblinator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as intended but needs adjustements in the client

@Elblinator

Copy link
Copy Markdown
Member

if motion is forwarded then the submitter are not cottectly copied
used users for copy:
Screenshot_20251014_142051

fowarded motion:
Screenshot_20251014_142130

payload

action: "motion.create_forwarded"
mark_amendments_as_forwarded: false
meeting_id: 2
origin_in: 5
reason: ""
text: "<p>u</p>"
title: "u"
use_original_number: false
use_original_submitter: true
with_amendments: false
with_attachments: false
with_change_recommendations: false

result

{
  "status_code": 200,
  "success": true,
  "message": "Actions handled successfully",
  "results": [
    [
      {
        "id": 7,
        "sequential_number": 2,
        "non_forwarded_amendment_amount": 0,
        "amendment_result_data": []
      }
    ]
  ]
}

@Elblinator Elblinator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@Elblinator Elblinator removed their assignment Oct 14, 2025
@luisa-beerboom

Copy link
Copy Markdown
Member Author

I am guessing you would want it to say Deleted user, a (Test structure level a), Administrator (Test structure level).
Should Deleted user be translated in accordance with the meetings language?

@Elblinator

Elblinator commented Oct 15, 2025

Copy link
Copy Markdown
Member

Ye, please translate \o/

@vkrasnovyd vkrasnovyd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and well covered with tests.

@luisa-beerboom
luisa-beerboom enabled auto-merge (squash) November 4, 2025 12:31
@luisa-beerboom
luisa-beerboom merged commit 14cb374 into OpenSlides:main Nov 4, 2025
5 checks passed
vkrasnovyd pushed a commit to vkrasnovyd/openslides-backend that referenced this pull request Nov 25, 2025
vkrasnovyd pushed a commit to vkrasnovyd/openslides-backend that referenced this pull request Dec 1, 2025
vkrasnovyd pushed a commit to vkrasnovyd/openslides-backend that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement General enhancement which is neither bug nor feature Schrödinger projectname

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add reference for deleted accounts in submitters, spokesperson and editors

3 participants