Make change reco line changes updatable#3170
Merged
reiterl merged 4 commits intoOpenSlides:mainfrom Nov 7, 2025
Merged
Conversation
hjanott
reviewed
Oct 7, 2025
Comment on lines
+90
to
+95
| sorted_reco_data: list[tuple[int, int, int]] = sorted( | ||
| [ | ||
| (reco["line_from"], reco["line_to"], id_) | ||
| for id_, reco in motion_reco_data.items() | ||
| ] | ||
| ) |
Member
There was a problem hiding this comment.
Can be directly sorted.
Suggested change
| sorted_reco_data: list[tuple[int, int, int]] = sorted( | |
| [ | |
| (reco["line_from"], reco["line_to"], id_) | |
| for id_, reco in motion_reco_data.items() | |
| ] | |
| ) | |
| sorted_reco_data: list[tuple[int, int, int]] = sorted( | |
| (reco["line_from"], reco["line_to"], id_) | |
| for id_, reco in motion_reco_data.items() | |
| ) |
| ) | ||
|
|
||
| def test_update_with_line_changes_multi_motion(self) -> None: | ||
| self.create_motions_with_line_changes() |
Member
There was a problem hiding this comment.
This is basically the only test using two motions. So I would suggest passing such a list and use [1] as default.
Suggested change
| self.create_motions_with_line_changes() | |
| self.create_motions_with_line_changes([1, 2]) |
Member
|
The code should check, that:
|
…co-line-spans-updatable
Member
Author
Already doing that
To quote our wiki :
Already doing that |
…co-line-spans-updatable
hjanott
approved these changes
Nov 4, 2025
Member
hjanott
left a comment
hjanott
left a comment
There was a problem hiding this comment.
For what I requested; I like.
Member
|
The max line number check is implemented in the client. We don't want to reimplement the line number logic here. |
vkrasnovyd
pushed a commit
to vkrasnovyd/openslides-backend
that referenced
this pull request
Nov 25, 2025
* Make change reco line changes updatable * Requested changes
vkrasnovyd
pushed a commit
to vkrasnovyd/openslides-backend
that referenced
this pull request
Dec 1, 2025
* Make change reco line changes updatable * Requested changes Co-authored-by: Viktoriia Krasnovyd viktoriia.krasnovyd@intevation.de
vkrasnovyd
pushed a commit
to vkrasnovyd/openslides-backend
that referenced
this pull request
Dec 1, 2025
* Make change reco line changes updatable * Requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3169
Please test this with real data as well. Code may break if data corrupt.