[rel-DB] Complete checker tests#3216
Merged
vkrasnovyd merged 13 commits intoOpenSlides:feature/relational-dbfrom Nov 27, 2025
Merged
[rel-DB] Complete checker tests#3216vkrasnovyd merged 13 commits intoOpenSlides:feature/relational-dbfrom
vkrasnovyd merged 13 commits intoOpenSlides:feature/relational-dbfrom
Conversation
hjanott
requested changes
Nov 24, 2025
Member
hjanott
left a comment
There was a problem hiding this comment.
I see many beautiful changes.
Co-authored-by: Hannes Janott <hannes.janott@openslides.com>
hjanott
approved these changes
Nov 25, 2025
Member
hjanott
left a comment
There was a problem hiding this comment.
I just found one line that should be removed before merging.
Co-authored-by: Hannes Janott <hannes.janott@openslides.com>
Contributor
Author
|
@hjanott added some missing test cases, did a bit of cleanup in the checker itself and added a couple of todos for rel-db-2. Also re-enabled migration index check in the checker. |
hjanott
approved these changes
Nov 27, 2025
fe6890d
into
OpenSlides:feature/relational-db
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to presenters and tests:
export_helper.get_fields_for_exportin thecheck_database_all(logic similar toexport_meeting). Reason: checker was screaming because of the calculated fields pulled from db (likemediafile.owner_id_organization_idorprojection.content_object_id_meeting_id).Changes to checker: