Troubleshoot dysfunctional presenters#3371
Merged
luisa-beerboom merged 7 commits intoOpenSlides:mainfrom Feb 27, 2026
Merged
Conversation
Member
Author
|
This basically turns off the functionality by default. Assigning @hjanott for code review, @bastianjoel for testing the client and @peb-adr in case he wants to see if he can manage to connect to it when it is enabled, since I'm not sure at all if it works. |
Member
|
Do not wait for my review. |
e534035 to
16ca605
Compare
peb-adr
approved these changes
Feb 27, 2026
Member
peb-adr
left a comment
There was a problem hiding this comment.
As discussed make target name: open-gunicornc-<MOD>
Otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3368
maybe.
I've investigated the errors in the logs. They are from a new function of gunicorn (the control interface https://gunicorn.org/guides/gunicornc/).
(By the way, the code that fails is somewhere in ln 98-111 of https://github.com/benoitc/gunicorn/blob/master/gunicorn/ctl/server.py#L98C8-L112C1 after all that is the code wrapped by the try block that adds
Control server errorto the error message and after it there is an infoControl socket listening at %sbeing locked that never comes.[Errno 13] Permission deniedis an os error btw. Probably caused by accessing a file without appropriate rights.)I've added something to try and fix the gunicorn issue:
A new env setting
OPENSLIDES_BACKEND_ENABLE_CONTROL_SOCKET(false by default) that enables the control interface.If it is enabled the control sockets should be created as
openslides-action.ctlandopenslides-presenter.ctl.