Skip to content

Commit 32ddaad

Browse files
authored
Remove datastore from setup/config templates for relDB (#258)
1 parent e24c5ff commit 32ddaad

File tree

5 files changed

+12
-100
lines changed

5 files changed

+12
-100
lines changed

Makefile

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,16 @@ lint:
2222
gofmt:
2323
gofmt -l -s -w .
2424

25+
openslides:
26+
docker build . --target builder --tag openslides-manage-builder
27+
docker run --interactive --tty --volume $(dir $(mkfile_path)):/build/ --rm openslides-manage-builder sh -c " \
28+
if [ $(shell whoami) != root ]; then \
29+
addgroup -g $(shell id -g) build ; \
30+
adduser -u $(shell id -u) -G build -D build ; \
31+
chown build: /app/openslides ; \
32+
fi; \
33+
cp -p /app/openslides /build/"
34+
2535
########################## Deprecation List ##########################
2636

2737
mkfile_path := $(abspath $(lastword $(MAKEFILE_LIST)))
@@ -53,14 +63,4 @@ protoc: | deprecation-warning
5363
--go-grpc_out=require_unimplemented_servers=false:. --go-grpc_opt=paths=source_relative \
5464
proto/manage.proto
5565

56-
openslides: | deprecation-warning
57-
docker build . --target builder --tag openslides-manage-builder
58-
docker run --interactive --tty --volume $(dir $(mkfile_path)):/build/ --rm openslides-manage-builder sh -c " \
59-
if [ $(shell whoami) != root ]; then \
60-
addgroup -g $(shell id -g) build ; \
61-
adduser -u $(shell id -u) -G build -D build ; \
62-
chown build: /app/openslides ; \
63-
fi; \
64-
cp -p /app/openslides /build/"
65-
6666
.PHONY: openslides

pkg/config/config.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,6 @@ func NewYmlConfig(configFiles [][]byte) (*YmlConfig, error) {
233233
"backendAction",
234234
"backendPresenter",
235235
"backendManage",
236-
"datastoreReader",
237-
"datastoreWriter",
238236
"postgres",
239237
"autoupdate",
240238
"auth",

pkg/config/default-config.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@ defaultEnvironment:
2525
PRESENTER_HOST: backendPresenter
2626
PRESENTER_PORT: 9003
2727

28-
DATASTORE_READER_HOST: datastoreReader
29-
DATASTORE_READER_PORT: 9010
30-
DATASTORE_WRITER_HOST: datastoreWriter
31-
DATASTORE_WRITER_PORT: 9011
32-
3328
AUTOUPDATE_HOST: autoupdate
3429
AUTOUPDATE_PORT: 9012
3530

pkg/config/default-docker-compose.yml

Lines changed: 1 addition & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ services:
7878
image: {{ .ContainerRegistry }}/openslides-backend:{{ .Tag }}
7979
{{- if checkFlag $.DisableDependsOn }}{{ else }}
8080
depends_on:
81-
- datastoreWriter
8281
- auth
8382
- media
8483
- vote
@@ -131,7 +130,6 @@ services:
131130
image: {{ .ContainerRegistry }}/openslides-backend:{{ .Tag }}
132131
{{- if checkFlag $.DisableDependsOn }}{{ else }}
133132
depends_on:
134-
- datastoreWriter
135133
- postgres
136134
{{- end }}
137135
environment:
@@ -151,45 +149,6 @@ services:
151149
{{- end }}
152150

153151

154-
{{- with .Services.datastoreReader }}
155-
156-
datastoreReader:
157-
image: {{ .ContainerRegistry }}/openslides-datastore-reader:{{ .Tag }}
158-
{{- if checkFlag $.DisableDependsOn }}{{ else }}
159-
depends_on:
160-
- postgres
161-
{{- end }}
162-
environment:
163-
<< : *default-environment
164-
{{- with .Environment }}{{ marshalContent 6 . }}{{- end }}
165-
networks:
166-
- data
167-
secrets:
168-
- postgres_password
169-
{{- with .AdditionalContent }}{{ marshalContent 4 . }}{{- end }}
170-
{{- end }}
171-
172-
173-
{{- with .Services.datastoreWriter }}
174-
175-
datastoreWriter:
176-
image: {{ .ContainerRegistry }}/openslides-datastore-writer:{{ .Tag }}
177-
{{- if checkFlag $.DisableDependsOn }}{{ else }}
178-
depends_on:
179-
- postgres
180-
- redis
181-
{{- end }}
182-
environment:
183-
<< : *default-environment
184-
{{- with .Environment }}{{ marshalContent 6 . }}{{- end }}
185-
networks:
186-
- data
187-
secrets:
188-
- postgres_password
189-
{{- with .AdditionalContent }}{{ marshalContent 4 . }}{{- end }}
190-
{{- end }}
191-
192-
193152
{{- if checkFlag .DisablePostgres }}{{ else }}{{- with .Services.postgres }}
194153

195154
postgres:
@@ -216,7 +175,6 @@ services:
216175
image: {{ .ContainerRegistry }}/openslides-autoupdate:{{ .Tag }}
217176
{{- if checkFlag $.DisableDependsOn }}{{ else }}
218177
depends_on:
219-
- datastoreReader
220178
- redis
221179
{{- end }}
222180
environment:
@@ -239,7 +197,6 @@ services:
239197
image: {{ .ContainerRegistry }}/openslides-search:{{ .Tag }}
240198
{{- if checkFlag $.DisableDependsOn }}{{ else }}
241199
depends_on:
242-
- datastoreReader
243200
- postgres
244201
- autoupdate
245202
{{- end }}
@@ -285,7 +242,6 @@ services:
285242
image: {{ .ContainerRegistry }}/openslides-auth:{{ .Tag }}
286243
{{- if checkFlag $.DisableDependsOn }}{{ else }}
287244
depends_on:
288-
- datastoreReader
289245
- redis
290246
{{- end }}
291247
environment:
@@ -298,6 +254,7 @@ services:
298254
- auth_token_key
299255
- auth_cookie_key
300256
- internal_auth_password
257+
- postgres_password
301258
{{- with .AdditionalContent }}{{ marshalContent 4 . }}{{- end }}
302259
{{- end }}
303260

@@ -307,7 +264,6 @@ services:
307264
image: {{ .ContainerRegistry }}/openslides-vote:{{ .Tag }}
308265
{{- if checkFlag $.DisableDependsOn }}{{ else }}
309266
depends_on:
310-
- datastoreReader
311267
- auth
312268
- autoupdate
313269
- redis
@@ -367,7 +323,6 @@ services:
367323
image: {{ .ContainerRegistry }}/openslides-icc:{{ .Tag }}
368324
{{- if checkFlag $.DisableDependsOn }}{{ else }}
369325
depends_on:
370-
- datastoreReader
371326
- postgres
372327
- redis
373328
{{- end }}
@@ -391,7 +346,6 @@ services:
391346
image: {{ .ContainerRegistry }}/openslides-manage:{{ .Tag }}
392347
{{- if checkFlag $.DisableDependsOn }}{{ else }}
393348
depends_on:
394-
- datastoreReader
395349
- backendManage
396350
{{- end }}
397351
environment:

pkg/setup/setup_test.go

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -482,10 +482,6 @@ x-default-environment: &default-environment
482482
DATABASE_PASSWORD_FILE: /run/secrets/postgres_password
483483
DATABASE_PORT: "5432"
484484
DATABASE_USER: openslides
485-
DATASTORE_READER_HOST: datastoreReader
486-
DATASTORE_READER_PORT: "9010"
487-
DATASTORE_WRITER_HOST: datastoreWriter
488-
DATASTORE_WRITER_PORT: "9011"
489485
ICC_HOST: icc
490486
ICC_PORT: "9007"
491487
INTERNAL_AUTH_PASSWORD_FILE: /run/secrets/internal_auth_password
@@ -567,7 +563,6 @@ services:
567563
backendAction:
568564
image: ghcr.io/openslides/openslides/openslides-backend:latest
569565
depends_on:
570-
- datastoreWriter
571566
- auth
572567
- media
573568
- vote
@@ -604,7 +599,6 @@ services:
604599
backendManage:
605600
image: ghcr.io/openslides/openslides/openslides-backend:latest
606601
depends_on:
607-
- datastoreWriter
608602
- postgres
609603
environment:
610604
<< : *default-environment
@@ -620,30 +614,6 @@ services:
620614
- postgres_password
621615
- superadmin
622616
623-
datastoreReader:
624-
image: ghcr.io/openslides/openslides/openslides-datastore-reader:latest
625-
depends_on:
626-
- postgres
627-
environment:
628-
<< : *default-environment
629-
NUM_WORKERS: "8"
630-
networks:
631-
- data
632-
secrets:
633-
- postgres_password
634-
635-
datastoreWriter:
636-
image: ghcr.io/openslides/openslides/openslides-datastore-writer:latest
637-
depends_on:
638-
- postgres
639-
- redis
640-
environment:
641-
<< : *default-environment
642-
networks:
643-
- data
644-
secrets:
645-
- postgres_password
646-
647617
postgres:
648618
image: postgres:15
649619
environment:
@@ -661,7 +631,6 @@ services:
661631
autoupdate:
662632
image: ghcr.io/openslides/openslides/openslides-autoupdate:latest
663633
depends_on:
664-
- datastoreReader
665634
- redis
666635
environment:
667636
<< : *default-environment
@@ -676,7 +645,6 @@ services:
676645
search:
677646
image: ghcr.io/openslides/openslides/openslides-search:latest
678647
depends_on:
679-
- datastoreReader
680648
- postgres
681649
- autoupdate
682650
environment:
@@ -708,7 +676,6 @@ services:
708676
auth:
709677
image: ghcr.io/openslides/openslides/openslides-auth:latest
710678
depends_on:
711-
- datastoreReader
712679
- redis
713680
environment:
714681
<< : *default-environment
@@ -719,11 +686,11 @@ services:
719686
- auth_token_key
720687
- auth_cookie_key
721688
- internal_auth_password
689+
- postgres_password
722690
723691
vote:
724692
image: ghcr.io/openslides/openslides/openslides-vote:latest
725693
depends_on:
726-
- datastoreReader
727694
- auth
728695
- autoupdate
729696
- redis
@@ -762,7 +729,6 @@ services:
762729
icc:
763730
image: ghcr.io/openslides/openslides/openslides-icc:latest
764731
depends_on:
765-
- datastoreReader
766732
- postgres
767733
- redis
768734
environment:
@@ -778,7 +744,6 @@ services:
778744
manage:
779745
image: ghcr.io/openslides/openslides/openslides-manage:latest
780746
depends_on:
781-
- datastoreReader
782747
- backendManage
783748
environment:
784749
<< : *default-environment

0 commit comments

Comments
 (0)