Skip to content

Init interface #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ufechner7 merged 22 commits into from
Jul 10, 2025
Merged

Init interface #242

ufechner7 merged 22 commits into from
Jul 10, 2025

Conversation

@ufechner7
Copy link
Member

@ufechner7 ufechner7 commented Jul 9, 2025 •
edited
Loading

  • set the integrator at the end of calling init!
  • rename init_sim! to init!
  • all all parameters that are valid for KPS3 and KPS4 also for SymbolicAWEModel
  • add tests
  • update CHANGE_LOG.md

@ufechner7 ufechner7 linked an issue Jul 9, 2025 that may be closed by this pull request
Implement AKM init! functions #153
Closed
5 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/symbolic_awe_model.jl 50.00% 2 Missing ⚠️
src/precompile.jl 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ufechner7 ufechner7 marked this pull request as ready for review July 9, 2025 16:32
@ufechner7 ufechner7 marked this pull request as draft July 9, 2025 18:27
@ufechner7
Copy link
Member Author

ufechner7 commented Jul 9, 2025

Both VortexStepMethod and KiteModels now export an init! function. This causes problems. I suggest not to merge this until we found a clean solution.

1-Bart-1
1-Bart-1 reviewed Jul 10, 2025
View reviewed changes
@ufechner7 ufechner7 requested a review from 1-Bart-1 July 10, 2025 21:33
@ufechner7 ufechner7 marked this pull request as ready for review July 10, 2025 21:47
@ufechner7 ufechner7 merged commit b221b9b into main Jul 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1-Bart-1 1-Bart-1 1-Bart-1 approved these changes

@baptistelabat baptistelabat Awaiting requested review from baptistelabat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement AKM init! functions

4 participants

@ufechner7 @codecov-commenter @1-Bart-1