-
-
Notifications
You must be signed in to change notification settings - Fork 4
Fix/improve for mpc #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 91.71% 88.93% -2.78%
==========================================
Files 5 5
Lines 1376 1374 -2
==========================================
- Hits 1262 1222 -40
- Misses 114 152 +38 ☔ View full report in Codecov by Sentry. |
|
Do I understand correctly that you add a new, simplified model for control purposes? If that is the case, can you perhaps change the title of the pull request and add some tests? |
|
No, the model still works the same. I found some mistake in the flap angle formula that I fixed, and updated some other things. I just had to move the code around a bit to be able to work with it from the other package, but the model is still the same otherwise. |
|
The simplified model just exists inside KitePredictiveControl.jl |
|
So do you think this pull request is ready to be merged? |
Fix bugs and add changes that improve the accuracy of the 3 line model and compatibility for https://github.com/Albatross-Kite-Transport/KitePredictiveControl.jl