Skip to content

Conversation

@1-Bart-1
Copy link
Member

Fix bugs and add changes that improve the accuracy of the 3 line model and compatibility for https://github.com/Albatross-Kite-Transport/KitePredictiveControl.jl

@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 81.94444% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.93%. Comparing base (786d581) to head (ef8f4af).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/KPS4_3L.jl 81.94% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   91.71%   88.93%   -2.78%     
==========================================
  Files           5        5              
  Lines        1376     1374       -2     
==========================================
- Hits         1262     1222      -40     
- Misses        114      152      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ufechner7
Copy link
Member

Do I understand correctly that you add a new, simplified model for control purposes? If that is the case, can you perhaps change the title of the pull request and add some tests?

@1-Bart-1
Copy link
Member Author

No, the model still works the same. I found some mistake in the flap angle formula that I fixed, and updated some other things. I just had to move the code around a bit to be able to work with it from the other package, but the model is still the same otherwise.

@1-Bart-1
Copy link
Member Author

The simplified model just exists inside KitePredictiveControl.jl

@ufechner7
Copy link
Member

So do you think this pull request is ready to be merged?

@ufechner7 ufechner7 merged commit 59a19fe into main Nov 14, 2024
5 of 6 checks passed
@1-Bart-1 1-Bart-1 deleted the fix/improve-for-mpc branch June 19, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants