Skip to content

Conversation

@dvanwolffelaar
Copy link
Collaborator

Solution to issue

@dvanwolffelaar dvanwolffelaar self-assigned this Nov 15, 2024
@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.65%. Comparing base (b108d53) to head (2924354).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files           5        5           
  Lines        1366     1366           
=======================================
  Hits         1252     1252           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ufechner7
Copy link
Member

ufechner7 commented Nov 15, 2024

Good starting point, but you can get all vectors from the settings file. So the script should print the resulting inertia based on the settings.

Copy link
Member

@ufechner7 ufechner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is missing is a main program, that calls one of your functions and prints the result. OK, I see you print the results in one of the functions. But this is not so good, a function that has a name starting with calculate_... should not print anything.

@ufechner7 ufechner7 merged commit baa85f1 into main Nov 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a script that calculates the rotational inertia around each of the three axis

3 participants