Skip to content

Conversation

@1-Bart-1
Copy link
Member

@1-Bart-1 1-Bart-1 commented Apr 2, 2025

closes #76

  • Adds tests for settings_ram.yaml
  • Removes outdated 3l model

@1-Bart-1 1-Bart-1 requested a review from ufechner7 April 2, 2025 13:59
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.09%. Comparing base (d792f14) to head (ced86c7).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/settings.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   85.20%   84.09%   -1.12%     
==========================================
  Files          14       14              
  Lines         987      918      -69     
==========================================
- Hits          841      772      -69     
  Misses        146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ufechner7 ufechner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please answer the inline questions.

@ufechner7
Copy link
Member

One issue to address.

@1-Bart-1 1-Bart-1 merged commit 593ee03 into main Apr 8, 2025
8 checks passed
@1-Bart-1 1-Bart-1 deleted the ram branch April 8, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-define obligatory and non-obligatory sections

3 participants