Skip to content

warn on unknown solver and fall back to FBDF#159

Merged
1-Bart-1 merged 3 commits intomainfrom
claude/issue-156-20260321-1433
Mar 21, 2026
Merged

warn on unknown solver and fall back to FBDF#159
1-Bart-1 merged 3 commits intomainfrom
claude/issue-156-20260321-1433

Conversation

@1-Bart-1
Copy link
Member

Instead of throwing an error when an unknown solver is specified (e.g. DFBDF from default KiteUtils settings), emit a warning and fall back to FBDF.

Fixes #156

Generated with Claude Code

Instead of throwing an error when an unknown solver is specified
(e.g. DFBDF from default KiteUtils settings), emit a warning and
fall back to FBDF.

Fixes #156

Co-authored-by: Bart van de Lint <1-Bart-1@users.noreply.github.com>
@1-Bart-1
Copy link
Member Author

@claude add Readme code to test/test_setup.sh. Also the 2plate kite example in the README now doesn't run

using SymbolicAWEModels
SymbolicAWEModels.init_module(; force=false)

which will cause it to fail.

@claude
Copy link

claude bot commented Mar 21, 2026

Claude finished @1-Bart-1's task in 5m 18s —— View job


Changes pushed

  • Read README and test/test_setup.sh to understand current state
  • Fix README 2plate kite example: add SymbolicAWEModels.init_module(; force=false)
  • Fix README pendulum example: add init_module(; force=false) + set_data_path("data/base") (also broken — Settings("system.yaml") needs an explicit data path)
  • Add README pendulum code test to test/test_setup.sh
  • Add README 2plate kite code test to test/test_setup.sh
  • Commit and push changes

Summary

README.md — two code blocks fixed:

  1. Pendulum example: added SymbolicAWEModels.init_module(; force=false) and set_data_path("data/base") — without these, Settings("system.yaml") had no valid yaml to load on a fresh install.
  2. 2-Plate kite example: added SymbolicAWEModels.init_module(; force=false) right after the using line, as requested.

test/test_setup.sh — two new test blocks appended (after the existing example runs):

  • README pendulum example — runs the exact README pendulum code inline in a fresh Julia process
  • README 2plate kite example — runs the exact README 2plate kite code inline in a fresh Julia process

Both tests benefit from the existing init_module() call earlier in the script (which copies data into the temp dir), so subsequent Julia processes see the data directory and __init__() sets the data path automatically.
|

- Add SymbolicAWEModels.init_module(; force=false) to README 2plate kite
  example so data files are copied before set_data_path is called
- Add init_module + set_data_path("data/base") to README pendulum example
  which was also missing proper data path setup (Settings("system.yaml")
  needs an explicit data directory)
- Add README pendulum code as an integration test in test/test_setup.sh
- Add README 2plate kite code as an integration test in test/test_setup.sh

Co-authored-by: Bart van de Lint <1-Bart-1@users.noreply.github.com>
@1-Bart-1
Copy link
Member Author

@claude update the changelog

@claude
Copy link

claude bot commented Mar 21, 2026

Claude finished @1-Bart-1's task in 45s —— View job


Changes pushed

  • Gather context
  • Find and read changelog file
  • Review PR changes
  • Update changelog
  • Commit and push

Added a v0.7.3 21-03-2026 entry to CHANGELOG.md covering:

  • Fixed — unknown solver warns and falls back to FBDF instead of throwing
  • Fixed — README examples now include the required init_module(; force=false) call
  • Fixed — README pendulum example adds set_data_path("data/base")
  • Tests — README pendulum and 2-plate kite examples added to test/test_setup.sh
    ·

Co-authored-by: Bart van de Lint <1-Bart-1@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/model_management.jl 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@1-Bart-1 1-Bart-1 merged commit 506fdbb into main Mar 21, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in readme example

2 participants