Add a field `point_idxs::Vector{Int16}` to the `Winch` struct. Check that each of these points is part of exactly one tether.

[1-Bart-1]

Instead of looping over tethers/segments/points to find the static point that probably is the winch point, a specific index should be provided.

• Add the index here:

  SymbolicAWEModels.jl/src/system_structure.jl

  Line 374 in 1fd0932

  mutable struct Winch

  
  It should be a const, because the structure of the system cannot be changed, only scalar values can be changed.
• update the Winch constructor
• update the Winch docs
• Remove the loop and just use the point_idx here:

  SymbolicAWEModels.jl/src/mtk_model.jl

  Line 565 in 1fd0932

  for segment_idx in tethers[tether_idx].segment_idxs

[abavoil]

• added test here, is it correct?

  SymbolicAWEModels.jl/src/system_structure.jl

  Lines 744 to 749 in ba170e0

  	nb_segments_per_point = Dict(p.idx => sum(p.idx in s.point_idxs for s in segments) for p in points)
  	for (i, winch) in enumerate(winches)
  	@assert winch.idx == i
  	for point_idx in winch.point_idxs
  	@assert nb_segments_per_point[point_idx] == 1
  	end

  I don't see many one letter variables in the code so maybe the naming is wrong, it felt easier to read in this case but feel free to change it!

[1-Bart-1]

I do these checks in src/mtk_model.jl, like this test to make sure that kite points are part of either 0 or 1 groups. I also add an error message instead of using @assert. I use for loops for readability.

SymbolicAWEModels.jl/src/mtk_model.jl

Lines 214 to 221 in ba170e0

	for group_ in groups
	if point.idx in group_.point_idxs
	group = group_
	found += 1
	end
	end
	!(found in [0,1]) && error("Kite point number $(point.idx) is part of $found groups,
	and should be part of exactly 0 or 1 groups.")

Your check will be here:

SymbolicAWEModels.jl/src/mtk_model.jl

Line 559 in ba170e0

for winch in winches

[abavoil]

Very nice!

[abavoil]

Oh and I checked "exactly one segment" intead of "exactly one tether"...
Something like this then?

for winch in winches
  for winch_point_idx in winch.point_idxs
    found = 0
    for tether_idx in winch.tether_idxs
      for segment_idx in tethers[tether_idx].segment_idxs
        for segment_point_idx in segments[segment_idx].point_idxs
          if winch_point_idx == segment_point_idx
            found += 1
    [ends]
    !(found == 1) && error("...")
[ends]

[1-Bart-1]

Yes, that looks about right ;)

[1-Bart-1]

I implemented something similar to this in #28