#186 attempt at resolving windows issues

Author: jellepoland

test/body_aerodynamics/test_body_aerodynamics.jl

@@ -414,39 +414,23 @@ end
 end
 
 @testset "set_va! with VSMSettings" begin
-    # Use module-specific test data files
-    wing_file = test_data_path("body_aerodynamics", "test_wing.yaml")
-    settings_file = create_temp_wing_settings("body_aerodynamics", "test_wing.yaml"; alpha=10.0, beta=5.0, wind_speed=15.0)
-    
+    settings_file = create_temp_wing_settings("body_aerodynamics", "test_wing.yaml";
+                                              alpha=10.0, beta=5.0, wind_speed=15.0)
     try
-        # Test set_va! with VSMSettings
-        settings = VSMSettings(settings_file)
-        wing = Wing(settings)
-        body_aero = BodyAerodynamics([wing])
-        
-        # Set velocity using convenience method
+        settings   = VSMSettings(settings_file)
+        wing       = Wing(settings)
+        body_aero  = BodyAerodynamics([wing])
+
         set_va!(body_aero, settings)
-        
-        # Calculate expected velocity vector
-        α = deg2rad(10.0)
-        β = deg2rad(5.0)
-        wind_speed = 15.0
-        expected_va = wind_speed * [
-            cos(α)*cos(β),  # X_b (forward)
-            sin(β),         # Y_b (right)
-            sin(α)*cos(β)   # Z_b (down)
-        ]
-        
-        # Verify that all panels have the correct velocity
-        for panel in body_aero.panels
-            @test panel.va ≈ expected_va atol=1e-10
+
+        α, β, wind_speed = deg2rad(10.0), deg2rad(5.0), 15.0
+        expected_va = wind_speed .* [cos(α)*cos(β), sin(β), sin(α)*cos(β)]
+
+        for p in body_aero.panels
+            @test p.va ≈ expected_va atol=1e-10
         end
-        
-        # Verify body_aero._va is set correctly
         @test body_aero._va ≈ expected_va atol=1e-10
-        
     finally
-        # Cleanup
-        rm(settings_file; force=true)
+        isfile(settings_file) && rm(settings_file; force=true)
     end
-end
+end

test/test_data_utils.jl

@@ -65,50 +65,49 @@ settings_file = create_temp_wing_settings("body_aerodynamics", "test_wing.yaml";
 rm(settings_file)
 ```
 """
-function create_temp_wing_settings(module_name, wing_file; 
-                                 name="test_wing",
-                                 n_panels=4,
-                                 n_groups=2,
-                                 spanwise_panel_distribution="COSINE",
-                                 spanwise_direction=[0.0, 1.0, 0.0],
-                                 remove_nan=true,
-                                 aerodynamic_model_type="VSM",
-                                 density=1.225,
-                                 type_initial_gamma_distribution="ZEROS",
-                                 alpha=10.0,
-                                 beta=5.0,
-                                 wind_speed=15.0)
-    
-    # Use wing_file path directly if it's already an absolute path, otherwise construct it
-    wing_file_path = if isabspath(wing_file)
-        wing_file
-    else
-        test_data_path(module_name, wing_file)
-    end
-    
-    settings_content = """
-wings:
-  - name: "$name"
-    geometry_file: "$wing_file_path"
-    n_panels: $n_panels
-    n_groups: $n_groups
-    spanwise_panel_distribution: $spanwise_panel_distribution
-    spanwise_direction: $spanwise_direction
-    remove_nan: $remove_nan
-
-solver_settings:
-  aerodynamic_model_type: $aerodynamic_model_type
-  density: $density
-  type_initial_gamma_distribution: $type_initial_gamma_distribution
-
-condition:
-  alpha: $alpha
-  beta: $beta
-  wind_speed: $wind_speed
-"""
-    
+function create_temp_wing_settings(module_name, wing_file;
+    name="test_wing",
+    n_panels=4,
+    n_groups=2,
+    spanwise_panel_distribution="COSINE",
+    spanwise_direction=[0.0, 1.0, 0.0],
+    remove_nan=true,
+    aerodynamic_model_type="VSM",
+    density=1.225,
+    type_initial_gamma_distribution="ZEROS",
+    alpha=10.0,
+    beta=5.0,
+    wind_speed=15.0,
+)
+    wing_file_path = isabspath(wing_file) ? wing_file : test_data_path(module_name, wing_file)
+    wing_file_path = replace(normpath(wing_file_path), '\\' => '/')
+
+    doc = Dict(
+        "wings" => [Dict(
+            "name" => name,
+            "geometry_file" => wing_file_path,
+            "n_panels" => n_panels,
+            "n_groups" => n_groups,
+            "spanwise_panel_distribution" => spanwise_panel_distribution,
+            "spanwise_direction" => spanwise_direction,
+            "remove_nan" => remove_nan,
+        )],
+        "solver_settings" => Dict(
+            "aerodynamic_model_type" => aerodynamic_model_type,
+            "density" => density,
+            "type_initial_gamma_distribution" => type_initial_gamma_distribution,
+        ),
+        "condition" => Dict(
+            "alpha" => alpha,
+            "beta" => beta,
+            "wind_speed" => wind_speed,
+        ),
+    )
+
     temp_file = joinpath(tempdir(), "temp_wing_settings_$(randstring(8)).yaml")
-    write(temp_file, settings_content)
+    open(temp_file, "w") do io
+        YAML.write(io, doc)
+    end
     return temp_file
 end
 
@@ -154,3 +153,4 @@ function get_complete_settings_file(module_name)
         return create_temp_wing_settings(module_name, basename(get_standard_wing_file(module_name)))
     end
 end
+